Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-exporting types for google-common #1271

Merged
merged 8 commits into from Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/bigquery.ts
Expand Up @@ -21,6 +21,7 @@
GoogleAuthOptions,
util,
} from '@google-cloud/common';
import * as common from '@google-cloud/common';
import {paginator, ResourceStream} from '@google-cloud/paginator';
import {promisifyAll} from '@google-cloud/promisify';
import {PreciseDate} from '@google-cloud/precise-date';
Expand All @@ -45,6 +46,9 @@
import {GoogleErrorBody} from '@google-cloud/common/build/src/util';
import bigquery from './types';

// Third-Party Re-exports
export {common};

export interface RequestCallback<T> {
(err: Error | null, response?: T | null): void;
}
Expand Down Expand Up @@ -308,17 +312,17 @@
export class BigQuery extends Service {
location?: string;

createQueryStream(options?: Query | string): ResourceStream<RowMetadata> {

Check warning on line 315 in src/bigquery.ts

View workflow job for this annotation

GitHub Actions / lint

'options' is defined but never used
// placeholder body, overwritten in constructor
return new ResourceStream<RowMetadata>({}, () => {});
}

getDatasetsStream(options?: GetDatasetsOptions): ResourceStream<Dataset> {

Check warning on line 320 in src/bigquery.ts

View workflow job for this annotation

GitHub Actions / lint

'options' is defined but never used
// placeholder body, overwritten in constructor
return new ResourceStream<Dataset>({}, () => {});
}

getJobsStream(options?: GetJobsOptions): ResourceStream<Job> {

Check warning on line 325 in src/bigquery.ts

View workflow job for this annotation

GitHub Actions / lint

'options' is defined but never used
// placeholder body, overwritten in constructor
return new ResourceStream<Job>({}, () => {});
}
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
Expand Up @@ -25,6 +25,7 @@ export {
BigQueryTime,
BigQueryTimeOptions,
BigQueryTimestamp,
common,
DatasetCallback,
DatasetResource,
DatasetResponse,
Expand Down