System tests not removing stale dataset resources

[steffnay]

The system tests are expected to delete stale testing datasets (identified by the GCLOUD_TESTS_PREFIX label) that are at east 24 hours old.

  async function deleteDatasets() {
    const [datasets] = await bigquery.getDatasets({
      filter: `labels.${GCLOUD_TESTS_PREFIX}`,
    });

    const deleteDatasetPromises = datasets
      .filter(dataset => {
        const creationTime = dataset.metadata.creationTime;
        return creationTime && isResourceStale(creationTime);
      })
      .map(dataset => {
        return dataset.delete({force: true});
      });

    await Promise.all(deleteDatasetPromises);
  }

The deleteDatasets() method attempts to access the dataset's creation time via metadata on the dataset object returned by bigquery.getDatasets(), however these objects do not contain the creationTime field. Because of this, the ages of the datasets are never calculated and the resources persist indefinitely.

[steffnay]

Fixed by #717