tests(system): updates tests to identify & delete stale dataset resources

[steffnay]

• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

🦕

[codecov]

Codecov Report

Merging #717 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files           7        7           
  Lines        6307     6307           
  Branches      369      406   +37     
=======================================
  Hits         6002     6002           
  Misses        305      305           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92599f9...854343a. Read the comment docs.

[stephenplusplus]

I was able to only make this change from master and it seemed to be working:

diff --git a/system-test/bigquery.ts b/system-test/bigquery.ts
index fe7007e..b0e2d36 100644
--- a/system-test/bigquery.ts
+++ b/system-test/bigquery.ts
@@ -1699,9 +1699,9 @@ describe('BigQuery', () => {
     });
 
     const deleteDatasetPromises = datasets
-      .filter(dataset => {
-        const creationTime = dataset.metadata.creationTime;
-        return creationTime && isResourceStale(creationTime);
+      .filter(async dataset => {
+        const [metadata] = await dataset.getMetadata();
+        return isResourceStale(parseInt(metadata.creationTime));
       })
       .map(dataset => {
         return dataset.delete({force: true});

Good catch on the dataset.metadata object not holding the creationTime property.

I was looking at creationTime as documented here, and it says

string (int64 format)

Output only. The time when this dataset was created, in milliseconds since the epoch.

Is it true it could be undefined or something else?

[steffnay]

@stephenplusplus Sweet, that's so much easier. creationTime should never be undefined. I think this fixes the issue.