Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manual update for renovate-bot google cloud storage v7 #1262

Merged
merged 5 commits into from
Aug 17, 2023
Merged

fix: manual update for renovate-bot google cloud storage v7 #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51fd66f
fix(deps): update dependency @google-cloud/storage to v7
renovate-bot Aug 15, 2023
8611846
updating system tests to accommodate version update
Aug 15, 2023
61c7b79
reset formatting
Aug 17, 2023
2008aef
Revert "updating system tests to accommodate version update"
Aug 17, 2023
1c78ba0
updating system tests to accommodate version update
Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"uuid": "^9.0.0"
},
"devDependencies": {
"@google-cloud/storage": "^6.0.0",
"@google-cloud/storage": "^7.0.0",
"@types/big.js": "^6.2.0",
"@types/extend": "^3.0.1",
"@types/is": "0.0.22",
Expand Down
10 changes: 4 additions & 6 deletions samples/authViewTutorial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@ function main(
sharedMetadata.access = sharedAccessEntries;

// Make API request to update dataset metadata
const [updatedSharedMetadata] = await sharedDataset.setMetadata(
sharedMetadata
);
const [updatedSharedMetadata] =
await sharedDataset.setMetadata(sharedMetadata);

console.log(`Dataset ${updatedSharedMetadata.id} updated.`);
// [END bigquery_avt_shared_dataset_access]
Expand All @@ -129,9 +128,8 @@ function main(
sourceMetadata.access = sourceAccessEntries;

// Make API request to update source dataset metadata
const [updatedSourceMetadata] = await sourceDataset.setMetadata(
sourceMetadata
);
const [updatedSourceMetadata] =
await sourceDataset.setMetadata(sourceMetadata);

console.log(`Dataset ${updatedSourceMetadata.id} updated.`);
// [END bigquery_avt_source_dataset_access]
Expand Down
2 changes: 1 addition & 1 deletion samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"dependencies": {
"@google-cloud/bigquery": "^7.1.1",
"@google-cloud/storage": "^6.0.0",
"@google-cloud/storage": "^7.0.0",
"google-auth-library": "^9.0.0",
"readline-promise": "^1.0.4",
"yargs": "^17.0.0"
Expand Down
10 changes: 9 additions & 1 deletion system-test/bigquery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1818,7 +1818,15 @@ describe('BigQuery', () => {
});

const deleteBucketPromises = buckets
.filter(bucket => isResourceStale(bucket.metadata.timeCreated))
.filter(bucket => {
try {
if (typeof bucket.metadata.timeCreated === 'string') {
isResourceStale(bucket.metadata.timeCreated);
}
} catch {
throw Error('timeCreated on type BucketMetadata cannot be undefined');
}
})
.map(async b => {
const [files] = await b.getFiles();
await Promise.all(files.map(f => f.delete()));
Expand Down