Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not cancel stream after server returned ok or cancelled status #1029

Merged
merged 4 commits into from Mar 16, 2022
Merged

fix: do not cancel stream after server returned ok or cancelled status #1029

merged 4 commits into from Mar 16, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Mar 16, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@mutianf mutianf requested review from a team as code owners March 16, 2022 16:55
igorbernstein2
igorbernstein2 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2022
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Mar 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2022
@mutianf mutianf closed this Mar 16, 2022
@mutianf mutianf reopened this Mar 16, 2022
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@mutianf mutianf merged commit 33754a2 into googleapis:main Mar 16, 2022
@release-please release-please bot mentioned this pull request Mar 16, 2022
Merged
@mutianf mutianf deleted the end_stream branch March 16, 2022 20:00
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 16, 2022
@release-please
chore(main): release 3.9.4 (#1030)
bb92d2e 
馃 I have created a release *beep* *boop*
---


### [3.9.4](v3.9.3...v3.9.4) (2022-03-16)


### Bug Fixes

* do not cancel stream after server returned ok or cancelled status ([#1029](#1029)) ([33754a2](33754a2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mutianf @igorbernstein2 @yoshi-kokoro