Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes #1070

Merged
merged 1 commit into from Apr 13, 2022
Merged

feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes #1070

merged 1 commit into from Apr 13, 2022

Conversation

igorbernstein2
Copy link
Contributor

Unify retriable status codes for ReadRows and MutateRows to be DEADLINE_EXCEEDED - RESOURCE_EXHAUSTED, ABORTED, UNAVAILABLE.

@igorbernstein2
feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes
c9aa1e1 
Unify retriable status codes for ReadRows and MutateRows to be DEADLINE_EXCEEDED -  RESOURCE_EXHAUSTED, ABORTED, UNAVAILABLE.
@igorbernstein2 igorbernstein2 requested review from a team as code owners April 13, 2022 19:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Apr 13, 2022
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2022
danieljbruce
danieljbruce approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@danieljbruce danieljbruce left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not too sure why idempotent requests would retry based on a different error set before so it seems reasonable to retry based on the same set of errors no matter what type of call we make as per the changes.

test/table.ts Show resolved Hide resolved
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6832df7 into googleapis:main Apr 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2022
@release-please release-please bot mentioned this pull request Apr 13, 2022
Merged
@igorbernstein2 igorbernstein2 deleted the res-ex branch April 13, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljbruce danieljbruce danieljbruce approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorbernstein2 @danieljbruce