fix: remove the watermarks #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the watermarks allows data not to be stuck at the last transform so that data doesn’t get stuck due to the watermarks.
product-auto-label
bot
added
size: xs
ruyadorno
reviewed
Aug 14, 2023
| @@ -252,6 +252,7 @@ describe('Bigtable/ReadRows', () => { | |||
| // Transform stream | |||
| const transform = new Transform({ | |||
| objectMode: true, | |||
| writableHighWaterMark: 0, | |||
There was a problem hiding this comment.
why is writableHighWaterMark only set in the test and not in the implementation (in src/table.ts) similar to readableHighWaterMark ?
There was a problem hiding this comment.
Prior to this PR, data gets trapped between this transform and the readStream transform and when the user cancels the stream the data is released resulting in extra rows. Removing the two watermarks prevents the data from getting trapped which means when the user cancels the streams no extra trapped data gets through so the right number of rows reaches the user.
igorbernstein2
approved these changes
Aug 15, 2023
ruyadorno
approved these changes
Aug 15, 2023
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the watermarks allows data not to be stuck at the last transform so that data doesn’t get stuck due to the watermarks.
Fixes #1286