Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up 'metadata' event for mutate request #991

Closed
mutianf opened this issue Jan 20, 2022 · 5 comments
Closed

Bubble up 'metadata' event for mutate request #991

mutianf opened this issue Jan 20, 2022 · 5 comments
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mutianf
Copy link
Contributor

mutianf commented Jan 20, 2022

mutate request should emit 'metadata' event in the manual layer so applications can get useful metrics from response headers like gfe 'server-timing'

@mutianf mutianf added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 20, 2022
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jan 20, 2022
@danieljbruce
Copy link
Contributor

danieljbruce commented Sep 23, 2022

I looked at what I get back from an error on the following test when using mutate instead of insert:

https://github.com/googleapis/nodejs-bigtable/blob/main/test/errors.ts#L105

It appears that the error includes metadata:

err.metadata = {"grpc-server-stats-bin":[{"type":"Buffer","data":[0,0,116,....,0]}]}

Do you mean metadata should be available when data is sent back as well?

@danieljbruce
Copy link
Contributor

Clarification: the bug is not talking about the metadata in the error. It is talking about the metadata grpc response which indeed includes headers like 'server-timing'.

@danieljbruce
Copy link
Contributor

#1178 is a possible fix.

@danieljbruce
Copy link
Contributor

#1180 contains the changes that include making metadata available to the user, but it seems like we are satisfied with providing it on the returned stream.

@danieljbruce
Copy link
Contributor

#1178 merged. Let me know if any more changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants