Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Commit

Permalink
feat: move ts target to es2018 from es2016 (#121)
Browse files Browse the repository at this point in the history 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9b55eba7-85ee-48d5-a737-8b677439db4d/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1c92077
  • Loading branch information
@yoshi-automation
yoshi-automation committed Jun 10, 2020
1 parent 2bed454 commit 59c5477
Show file tree
Hide file tree
Showing 10 changed files with 83 additions and 15 deletions.
32 changes: 32 additions & 0 deletions .kokoro/populate-secrets.sh
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/publish.sh
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 3 additions & 7 deletions .kokoro/release/publish.cfg
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .kokoro/trampoline.sh
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions protos/protos.d.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6281,6 +6281,9 @@ export namespace google {

/** FieldDescriptorProto options */
options?: (google.protobuf.IFieldOptions|null);

/** FieldDescriptorProto proto3Optional */
proto3Optional?: (boolean|null);
}

/** Represents a FieldDescriptorProto. */
Expand Down Expand Up @@ -6322,6 +6325,9 @@ export namespace google {
/** FieldDescriptorProto options. */
public options?: (google.protobuf.IFieldOptions|null);

/** FieldDescriptorProto proto3Optional. */
public proto3Optional: boolean;

/**
* Creates a new FieldDescriptorProto instance using the specified properties.
* @param [properties] Properties to set
Expand Down
28 changes: 25 additions & 3 deletions protos/protos.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
var $Reader = $protobuf.Reader, $Writer = $protobuf.Writer, $util = $protobuf.util;

// Exported root namespace
var $root = $protobuf.roots._google_cloud_cloudbuild_1_5_0_protos || ($protobuf.roots._google_cloud_cloudbuild_1_5_0_protos = {});
var $root = $protobuf.roots._google_cloud_cloudbuild_protos || ($protobuf.roots._google_cloud_cloudbuild_protos = {});

$root.google = (function() {

Expand Down Expand Up @@ -16189,6 +16189,7 @@
* @property {number|null} [oneofIndex] FieldDescriptorProto oneofIndex
* @property {string|null} [jsonName] FieldDescriptorProto jsonName
* @property {google.protobuf.IFieldOptions|null} [options] FieldDescriptorProto options
* @property {boolean|null} [proto3Optional] FieldDescriptorProto proto3Optional
*/

/**
Expand Down Expand Up @@ -16286,6 +16287,14 @@
*/
FieldDescriptorProto.prototype.options = null;

/**
* FieldDescriptorProto proto3Optional.
* @member {boolean} proto3Optional
* @memberof google.protobuf.FieldDescriptorProto
* @instance
*/
FieldDescriptorProto.prototype.proto3Optional = false;

/**
* Creates a new FieldDescriptorProto instance using the specified properties.
* @function create
Expand Down Expand Up @@ -16330,6 +16339,8 @@
writer.uint32(/* id 9, wireType 0 =*/72).int32(message.oneofIndex);
if (message.jsonName != null && Object.hasOwnProperty.call(message, "jsonName"))
writer.uint32(/* id 10, wireType 2 =*/82).string(message.jsonName);
if (message.proto3Optional != null && Object.hasOwnProperty.call(message, "proto3Optional"))
writer.uint32(/* id 17, wireType 0 =*/136).bool(message.proto3Optional);
return writer;
};

Expand Down Expand Up @@ -16394,6 +16405,9 @@
case 8:
message.options = $root.google.protobuf.FieldOptions.decode(reader, reader.uint32());
break;
case 17:
message.proto3Optional = reader.bool();
break;
default:
reader.skipType(tag & 7);
break;
Expand Down Expand Up @@ -16488,6 +16502,9 @@
if (error)
return "options." + error;
}
if (message.proto3Optional != null && message.hasOwnProperty("proto3Optional"))
if (typeof message.proto3Optional !== "boolean")
return "proto3Optional: boolean expected";
return null;
};

Expand Down Expand Up @@ -16610,6 +16627,8 @@
throw TypeError(".google.protobuf.FieldDescriptorProto.options: object expected");
message.options = $root.google.protobuf.FieldOptions.fromObject(object.options);
}
if (object.proto3Optional != null)
message.proto3Optional = Boolean(object.proto3Optional);
return message;
};

Expand Down Expand Up @@ -16637,6 +16656,7 @@
object.options = null;
object.oneofIndex = 0;
object.jsonName = "";
object.proto3Optional = false;
}
if (message.name != null && message.hasOwnProperty("name"))
object.name = message.name;
Expand All @@ -16658,6 +16678,8 @@
object.oneofIndex = message.oneofIndex;
if (message.jsonName != null && message.hasOwnProperty("jsonName"))
object.jsonName = message.jsonName;
if (message.proto3Optional != null && message.hasOwnProperty("proto3Optional"))
object.proto3Optional = message.proto3Optional;
return object;
};

Expand Down Expand Up @@ -18449,7 +18471,7 @@
* @memberof google.protobuf.FileOptions
* @instance
*/
FileOptions.prototype.ccEnableArenas = false;
FileOptions.prototype.ccEnableArenas = true;

/**
* FileOptions objcClassPrefix.
Expand Down Expand Up @@ -18898,7 +18920,7 @@
object.javaGenerateEqualsAndHash = false;
object.deprecated = false;
object.javaStringCheckUtf8 = false;
object.ccEnableArenas = false;
object.ccEnableArenas = true;
object.objcClassPrefix = "";
object.csharpNamespace = "";
object.swiftPrefix = "";
Expand Down
6 changes: 5 additions & 1 deletion protos/protos.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1632,6 +1632,10 @@
"options": {
"type": "FieldOptions",
"id": 8
},
"proto3Optional": {
"type": "bool",
"id": 17
}
},
"nested": {
Expand Down Expand Up @@ -1867,7 +1871,7 @@
"type": "bool",
"id": 31,
"options": {
"default": false
"default": true
}
},
"objcClassPrefix": {
Expand Down
7 changes: 7 additions & 0 deletions src/v1/cloud_build_client.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ export class CloudBuildClient {
}
opts.servicePath = opts.servicePath || servicePath;
opts.port = opts.port || port;

// users can override the config from client side, like retry codes name.
// The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
// The way to override client config for Showcase API:
//
// const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
// const showcaseClient = new showcaseClient({ projectId, customConfig });
opts.clientConfig = opts.clientConfig || {};

const isBrowser = typeof window !== 'undefined';
Expand Down
4 changes: 2 additions & 2 deletions synth.metadata
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-cloudbuild.git",
"sha": "aa7d99b9c02267808cac07f7691f5ce62f06ca14"
"sha": "2bed454946812b16a995422f773b2406a69d1d2d"
}
},
{
Expand All @@ -19,7 +19,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "be74d3e532faa47eb59f1a0eaebde0860d1d8ab4"
"sha": "1c92077459db3dc50741e878f98b08c6261181e0"
}
}
],
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"outDir": "build",
"resolveJsonModule": true,
"lib": [
"es2016",
"es2018",
"dom"
]
},
Expand Down

0 comments on commit 59c5477

Please sign in to comment.