fix: allow authentication with custom endpoint #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shaffeeullah
reviewed
Oct 6, 2021
| describe('customEndpoint (authentication attempted)', () => { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| let makeAuthenticatedRequest: any; | ||
| const config = {customEndpoint: true, useAuthWithCustomEndpoint: true}; |
There was a problem hiding this comment.
is the case where reqConfig.useAuthWithCustomEndpoint === undefined implicitly covered in existing tests? (guessing it is, but just want to double check). recommend adding an assert somewhere or a note verifying that auth is bypassed.
There was a problem hiding this comment.
Yes, there are existing tests that implicitly pass undefined and test. that auth is bypassed (
Line 826 in 2e400c6
shaffeeullah
approved these changes
Oct 6, 2021
danielbankhead
approved these changes
Oct 6, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [3.7.4](https://www.github.com/googleapis/nodejs-common/compare/v3.7.3...v3.7.4) (2021-10-06) ### Bug Fixes * allow authentication with custom endpoint ([#698](https://www.github.com/googleapis/nodejs-common/issues/698)) ([4c0f7ec](https://www.github.com/googleapis/nodejs-common/commit/4c0f7ec0c6ebedc34eaaab79fc053e7e889e243d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.8.0](https://www.github.com/googleapis/nodejs-common/compare/v3.7.3...v3.8.0) (2021-11-01) ### Features * Add retry support for 504 (Gateway Timeout) ([#704](https://www.github.com/googleapis/nodejs-common/issues/704)) ([5a3a96f](https://www.github.com/googleapis/nodejs-common/commit/5a3a96f5aa607e53d71e7ed9af5f26431af45679)) ### Bug Fixes * allow authentication with custom endpoint ([#698](https://www.github.com/googleapis/nodejs-common/issues/698)) ([4c0f7ec](https://www.github.com/googleapis/nodejs-common/commit/4c0f7ec0c6ebedc34eaaab79fc053e7e889e243d)) * update table.create to not reset id ([#700](https://www.github.com/googleapis/nodejs-common/issues/700)) ([b1ceb53](https://www.github.com/googleapis/nodejs-common/commit/b1ceb532ac7bf4852f430c83af5a71618ed42f54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕
This is the first step in addressing this issue.