feat: Customize retry implementation #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: began retry configuration implementation * 🦉 Updates from OwlBot * added semicolon * 🦉 Updates from OwlBot * removed log statement * refactored constants * updated retry-request and made relevant updates in this lib * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: implemented retry function * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * refactored retryableErrorFn into retry config * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * refactored code so test stub works as expected * removed print * added test * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * refactored function Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
google-cla
bot
added
the
cla: yes
shaffeeullah
commented
Jul 9, 2021
| return err && util.shouldRetryRequest(err); | ||
| }, | ||
| maxRetryDelay: config.retryOptions?.maxRetryDelay, | ||
| retryDelayMultiplier: config.retryOptions?.retryDelayMultiplier, | ||
| totalTimeout: config.retryOptions?.totalTimeout, |
There was a problem hiding this comment.
@stephenplusplus The system test is failing because it is passing retry-request undefined for these three values (maxRetryDelay, retryDelayMultiplier, and totalTimeout). Do you think that common should be defining defaults and always passing those defaults here? Or should retry-request be using its defaults if it receives an undefined value?
There was a problem hiding this comment.
retry-request! PTAL: googleapis/retry-request#37
There was a problem hiding this comment.
Amazing! Thank you :)
There was a problem hiding this comment.
Thanks for catching it! The fix is now released in 4.2.2.
bcoe
approved these changes
Jul 9, 2021
|
smh at myself. Sorry to auto-close this 😞 |
ddelgrosso1
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed for supporting retries in nodejs-storage. https://github.com/googleapis/nodejs-storage/pull/1493/files
Unit tests pass. Have tested locally linked with storage and that works as expected. Conformance testing will be written from storage to verify retry functionality further.
Adds the
RetryOptionsinterface which allows users to configureretryDelayMultiplier,totalTimeout,maxRetryDelay,autoRetry,maxRetries, andretryableErrorFn