fix: preserve default values in x-goog-request-params header (#620)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
googleapis · Sep 14, 2022 · 484a023 · 484a023
1 parent 4b62ef6
commit 484a023
Show file tree

Hide file tree

Showing 10 changed files with 2,128 additions and 1,762 deletions.
diff --git a/src/v1/autoscaling_policy_service_client.ts b/src/v1/autoscaling_policy_service_client.ts
@@ -457,7 +457,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createAutoscalingPolicy(
@@ -561,7 +561,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        'policy.name': request.policy!.name || '',
+        'policy.name': request.policy!.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.updateAutoscalingPolicy(
@@ -665,7 +665,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getAutoscalingPolicy(request, options, callback);
@@ -772,7 +772,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteAutoscalingPolicy(
@@ -886,7 +886,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listAutoscalingPolicies(
@@ -939,7 +939,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     const defaultCallSettings = this._defaults['listAutoscalingPolicies'];
     const callSettings = defaultCallSettings.merge(options);
@@ -997,7 +997,7 @@ export class AutoscalingPolicyServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     const defaultCallSettings = this._defaults['listAutoscalingPolicies'];
     const callSettings = defaultCallSettings.merge(options);

diff --git a/src/v1/batch_controller_client.ts b/src/v1/batch_controller_client.ts
@@ -574,7 +574,7 @@ export class BatchControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getBatch(request, options, callback);
@@ -660,7 +660,7 @@ export class BatchControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteBatch(request, options, callback);
@@ -784,7 +784,7 @@ export class BatchControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createBatch(request, options, callback);
@@ -914,7 +914,7 @@ export class BatchControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listBatches(request, options, callback);
@@ -955,7 +955,7 @@ export class BatchControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     const defaultCallSettings = this._defaults['listBatches'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1005,7 +1005,7 @@ export class BatchControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     const defaultCallSettings = this._defaults['listBatches'];
     const callSettings = defaultCallSettings.merge(options);

diff --git a/src/v1/cluster_controller_client.ts b/src/v1/cluster_controller_client.ts
@@ -636,9 +636,9 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        cluster_name: request.clusterName || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        cluster_name: request.clusterName ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getCluster(request, options, callback);
@@ -763,8 +763,8 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createCluster(request, options, callback);
@@ -988,9 +988,9 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        cluster_name: request.clusterName || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        cluster_name: request.clusterName ?? '',
       });
     this.initialize();
     return this.innerApiCalls.updateCluster(request, options, callback);
@@ -1149,9 +1149,9 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        cluster_name: request.clusterName || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        cluster_name: request.clusterName ?? '',
       });
     this.initialize();
     return this.innerApiCalls.stopCluster(request, options, callback);
@@ -1310,9 +1310,9 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        cluster_name: request.clusterName || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        cluster_name: request.clusterName ?? '',
       });
     this.initialize();
     return this.innerApiCalls.startCluster(request, options, callback);
@@ -1473,9 +1473,9 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        cluster_name: request.clusterName || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        cluster_name: request.clusterName ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteCluster(request, options, callback);
@@ -1624,9 +1624,9 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        cluster_name: request.clusterName || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        cluster_name: request.clusterName ?? '',
       });
     this.initialize();
     return this.innerApiCalls.diagnoseCluster(request, options, callback);
@@ -1776,8 +1776,8 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listClusters(request, options, callback);
@@ -1838,8 +1838,8 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     const defaultCallSettings = this._defaults['listClusters'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1909,8 +1909,8 @@ export class ClusterControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     const defaultCallSettings = this._defaults['listClusters'];
     const callSettings = defaultCallSettings.merge(options);

diff --git a/src/v1/job_controller_client.ts b/src/v1/job_controller_client.ts
@@ -589,8 +589,8 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     this.initialize();
     return this.innerApiCalls.submitJob(request, options, callback);
@@ -678,9 +678,9 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        job_id: request.jobId || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        job_id: request.jobId ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getJob(request, options, callback);
@@ -777,9 +777,9 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        job_id: request.jobId || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        job_id: request.jobId ?? '',
       });
     this.initialize();
     return this.innerApiCalls.updateJob(request, options, callback);
@@ -871,9 +871,9 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        job_id: request.jobId || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        job_id: request.jobId ?? '',
       });
     this.initialize();
     return this.innerApiCalls.cancelJob(request, options, callback);
@@ -962,9 +962,9 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
-        job_id: request.jobId || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
+        job_id: request.jobId ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteJob(request, options, callback);
@@ -1086,8 +1086,8 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     this.initialize();
     return this.innerApiCalls.submitJobAsOperation(request, options, callback);
@@ -1239,8 +1239,8 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listJobs(request, options, callback);
@@ -1305,8 +1305,8 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     const defaultCallSettings = this._defaults['listJobs'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1380,8 +1380,8 @@ export class JobControllerClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project_id: request.projectId || '',
-        region: request.region || '',
+        project_id: request.projectId ?? '',
+        region: request.region ?? '',
       });
     const defaultCallSettings = this._defaults['listJobs'];
     const callSettings = defaultCallSettings.merge(options);