Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaxOptions parameter is not optional in rollback() #309

Closed
evgenius opened this issue Jan 23, 2019 · 0 comments
Closed

gaxOptions parameter is not optional in rollback() #309

evgenius opened this issue Jan 23, 2019 · 0 comments
Assignees
@JustinBeckwith
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@evgenius
Copy link
Contributor

evgenius commented Jan 23, 2019 •
edited
Loading

By analogy with Transaction.commit()

nodejs-datastore/src/transaction.ts

Line 129 in 4bbe64f

commit(gaxOptions?, callback?) {

the first parameter of rollback(), gaxOptions, should be optional:

nodejs-datastore/src/transaction.ts

Line 363 in 4bbe64f

rollback(gaxOptions, callback?) {

@evgenius evgenius mentioned this issue Jan 23, 2019
Merged
2 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evgenius @JustinBeckwith @yoshi-automation