Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Error handling sample and add more documentation #83

Closed
trollkotze opened this issue May 1, 2018 · 2 comments · Fixed by #466
Closed

Improve the Error handling sample and add more documentation #83

trollkotze opened this issue May 1, 2018 · 2 comments · Fixed by #466
Assignees
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. docs type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@trollkotze
Copy link
Contributor

https://github.com/googleapis/nodejs-datastore/blob/master/samples/error.js

It would be good to have actual example of error handling, and/or complete documentation about what errors can occur and what they mean.

@stephenplusplus
Copy link
Contributor

I believe the upstream docs site should cover general error handling advice. Is this the type of information you're looking for: https://cloud.google.com/datastore/docs/concepts/errors? If so, we can link out to that page somewhere within the repo.

@alexander-fenster do you know where this sample actually shows up on the docs site?

@trollkotze
Copy link
Contributor Author

Thank you! That is useful. On my first encounter with that page I had not looked deep enough and thought these were only HTTP responses for the REST-API, without one-to-one correspondence to errors inside the client libs. Mea culpa!
Anyway, would be clearer if the client library's documentation and error handling sample would include these as well.

@JustinBeckwith JustinBeckwith changed the title Error handling sample is useless, and documentation non-existent Improve the Error handling sample and add more documentation May 31, 2018
@JustinBeckwith JustinBeckwith added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: enhancement labels Jun 5, 2019
@bcoe bcoe closed this as completed in #466 Sep 5, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. docs type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants