excludeFromIndexes: fix for entity elements inside arrays

[trollkotze]

Fixes #93
Fixes #100

• Tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[codecov]

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #101   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         645    646    +1     
=====================================
+ Hits          645    646    +1

Impacted Files	Coverage Δ
src/entity.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445304c...6bc2b90. Read the comment docs.

[googlebot]

CLAs look good, thanks!

[alexander-fenster]

@trollkotze Welcome, and thanks for your contribution!

@stephenplusplus that's your code I guess, can you please take a look?

[trollkotze]

I have now also added a simple fix for issue #93, with the example provided in that issue as a test.
This allows now something like:

entity = {
  key: key,
  excludeFromIndexes: ['arr[].a[].b'],
  data: {
    nestedArrayVariants: [
      {
        a: [{b:'something'},{c:'else'}],
      },{
        a: null,
      },{
        a: ['whatever'],
      }
    ],
  },
};

Previously, entityToEntityProto would have thrown a type error when encountering arr[i].a == null (or any other primitive value) while trying to exclude arr[].a[].b from indexes, thus disallowing detailed exclusion below nested properties that might sometimes be arrays and sometimes something else.
The fix is one simple property existence check that will rarely be traversed.

[JustinBeckwith]

@stephenplusplus @callmehiphop can someone take a look?

[stephenplusplus]

Awesome, thanks @trollkotze!

[evgenius]

Hi guys, is there any chance this fix is released soon?
I faced the same issue and even started working on a patch but then realised it's already here but just not released yet.