New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sum and average aggregation queries #1097
Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
ce9413f
Initial sum aggregation
danieljbruce cadb0cc
Modify encoding
danieljbruce 274c606
PropertyAggregateField with tests
danieljbruce a87e277
Improve transaction tests
danieljbruce 7548e81
Change the description in the describe block
danieljbruce aaaff65
Change return type to average
danieljbruce 02f0f7d
Make alias optional
danieljbruce 256a4d8
Fix the transaction tests to fail on rollback
danieljbruce 970c0f4
Add additional assertions to existing tests
danieljbruce ba7aef8
Revert "Add additional assertions to existing tests"
danieljbruce 3a204f5
Add describe block for comparing equivalent query
danieljbruce b403185
Average, sum and count toProto tests
danieljbruce 8312db7
Add tests for the sum aggregation
danieljbruce 035df48
Add a test for sum and snapshot reads
danieljbruce 6a44483
Add two test blocks for special cases
danieljbruce cfd745e
Export aggregate field from the client
danieljbruce d74c158
Merge branch 'main' of https://github.com/googleapis/nodejs-datastore…
danieljbruce a67b34b
PR follow-up changes
danieljbruce 4d58133
Adjust the values so that tests pass
danieljbruce e3b2c62
Add average aggregations
danieljbruce 5164596
Add snapshot reads for run query and aggregate q
danieljbruce 7db60c1
Remove Google error and entity filter
danieljbruce 8868bbb
Should use null for an aggregation query read time
danieljbruce ff2cd79
Remove tests from a bad cherry pick
danieljbruce e3b6841
Merge branch 'main' of https://github.com/googleapis/nodejs-datastore…
danieljbruce 6acfb77
Linting fix
danieljbruce 530df2c
Do the test on rating instead of appearances
danieljbruce eea8602
The assertion says the request should have failed
danieljbruce 8c4db96
Add a comment about using limits in test
danieljbruce c7de99c
Add rollbacks to transaction tests
danieljbruce a57c4a8
refactor getSharedOptionsOnly
danieljbruce 8ee7061
Remove test related to snapshot reads
danieljbruce 4f01c43
Add a test for multiple types of aggregates
danieljbruce 5be7d69
Correct descriptions of two tests on overflow
danieljbruce 0ed5509
Merge branch 'main' into sum-avg
danieljbruce 3b53859
Add a comment for setting the alias
danieljbruce af55599
Add tests to compare various ways to encode alias
danieljbruce 98afdd6
Added tests for when an empty alias is provided
danieljbruce 15840dd
Add a comment clarifying the use of snapshot reads
danieljbruce bbff19f
Add two tests to explore mixed aggregations alias
danieljbruce 2b66bae
Better names for some internal private functions
danieljbruce 6d882a3
Add a comment explaining why the sleep is needed
danieljbruce f7a6873
Add getReadTime function and use for sum/avg
danieljbruce 3681c06
Rename variable to emptyData
danieljbruce File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to "emptyData"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done