test: Add a test to ensure that snapshot reads works for runQuery #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing getSharedOptionsOnly allows us to use that function in two different places to avoid a repeated block of code. # Conflicts: # src/request.ts
The future refactor must implement the TODOs so that there is less repeated code in the codebase. Also, this commit implements snapshot reads for queries and adds a test for the snapshot reads. # Conflicts: # src/request.ts # system-test/datastore.ts
product-auto-label
bot
added
size: m
…into snapshot-reads-other-pr # Conflicts: # src/request.ts # system-test/datastore.ts
product-auto-label
bot
added
size: xs
danieljbruce
changed the title
|
With the refactor now done in the sum/avg PR, this PR just involves adding a test to ensure that runQuery works for snapshot reads. |
danieljbruce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that snapshot reads works for both aggregate queries and regular queries. A refactor is needed so that both types of queries can use the code that parses the readTime option.