Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow the user to set fallback to rest #1203

Merged
merged 30 commits into from
Dec 11, 2023

Commits on Nov 17, 2023

  1. Allow the user to set fallback to rest

    This provides a workaround for the connection issue.
    danieljbruce committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    bf9c81f View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    778f20e View commit details
    Browse the repository at this point in the history
  2. Putting together a test that mocks out gapic

    Need to mock out Gapic and compare constructors
    danieljbruce committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b6ce5d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99ef146 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. This harness works properly

    The harness mocks out the constructor and calls reach the constructor as well as the get function. So now we can see what values get passed into the constructor and get function.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4b8ab09 View commit details
    Browse the repository at this point in the history
  2. Add client testing module

    Add a working test that makes sure the rest parameter gets passed down to the gapic layer.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    60cbaed View commit details
    Browse the repository at this point in the history
  3. Regroup the code so it is better arranged

    Proper describe blocks make it easier for the code to be arranged so that with and without rest tests can be incorporated into the code.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d066264 View commit details
    Browse the repository at this point in the history
  4. Remove the datastore mock

    Remove the datastore mock. It is not necessary.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    fa5d14b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    591ce30 View commit details
    Browse the repository at this point in the history
  6. Clean up source code change

    Make a programmatic link to the data type so that the intent is clearer.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    fa56366 View commit details
    Browse the repository at this point in the history
  7. Add parameterized test

    Parameterized tests will allow us to delete half the tests. A new type is created for the test parameters.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    850781c View commit details
    Browse the repository at this point in the history
  8. Document the class for mocking datastore client

    Explain the purpose of the class. This will make it useful for testing.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    09ee75d View commit details
    Browse the repository at this point in the history
  9. Remove only

    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    115b40a View commit details
    Browse the repository at this point in the history
  10. Remove fallback params type

    This type is only used once so inline it.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    7f4a02a View commit details
    Browse the repository at this point in the history
  11. Remove changes to system tests

    Changes to system tests are not necessary. Remove them.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    92030db View commit details
    Browse the repository at this point in the history
  12. Add header

    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a42e8c6 View commit details
    Browse the repository at this point in the history
  13. Check for client existence

    assert resolves to falsy in tests. See if this solves the issue.
    danieljbruce committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e4bf66c View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Change it back

    Add console logs and assert checks back in.
    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    6faca17 View commit details
    Browse the repository at this point in the history
  2. Add more debugger logs

    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    54a0889 View commit details
    Browse the repository at this point in the history
  3. Add project load logs

    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f2ad045 View commit details
    Browse the repository at this point in the history
  4. console error

    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b532c8d View commit details
    Browse the repository at this point in the history
  5. Add comment for mocking out project id

    This should allow the unit tests to pass in the continuous integration environment.
    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    2e5700a View commit details
    Browse the repository at this point in the history
  6. linting fix

    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    31151be View commit details
    Browse the repository at this point in the history
  7. Correct title of describe block

    The title of the describe block should match the file. Remove console logs too.
    danieljbruce committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b3eda27 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Change rest parameter in test to fallback

    This parameter more specifically describes the change.
    danieljbruce committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3f97583 View commit details
    Browse the repository at this point in the history
  2. Create a simple system test for using rest

    This system test should show how the rest parameter is being used.
    danieljbruce committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    09233b5 View commit details
    Browse the repository at this point in the history
  3. Should check to see if entity is undefined

    This allows the test to pass with a simple assertion check.
    danieljbruce committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f009f7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c9a7153 View commit details
    Browse the repository at this point in the history
  5. Specify fallback type instead of string | undefin

    Fallback type is more specific . Use it instead.
    danieljbruce committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b5723a0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    afc8326 View commit details
    Browse the repository at this point in the history