-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow the user to set fallback to rest #1203
feat: Allow the user to set fallback to rest #1203
Commits on Nov 17, 2023
-
Allow the user to set fallback to rest
This provides a workaround for the connection issue.
Configuration menu - View commit details
-
Copy full SHA for bf9c81f - Browse repository at this point
Copy the full SHA bf9c81fView commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 778f20e - Browse repository at this point
Copy the full SHA 778f20eView commit details -
Putting together a test that mocks out gapic
Need to mock out Gapic and compare constructors
Configuration menu - View commit details
-
Copy full SHA for b6ce5d9 - Browse repository at this point
Copy the full SHA b6ce5d9View commit details -
Merge branch 'use-http-fallback' of https://github.com/danieljbruce/n…
…odejs-datastore into use-http-fallback
Configuration menu - View commit details
-
Copy full SHA for 99ef146 - Browse repository at this point
Copy the full SHA 99ef146View commit details
Commits on Dec 4, 2023
-
The harness mocks out the constructor and calls reach the constructor as well as the get function. So now we can see what values get passed into the constructor and get function.
Configuration menu - View commit details
-
Copy full SHA for 4b8ab09 - Browse repository at this point
Copy the full SHA 4b8ab09View commit details -
Add a working test that makes sure the rest parameter gets passed down to the gapic layer.
Configuration menu - View commit details
-
Copy full SHA for 60cbaed - Browse repository at this point
Copy the full SHA 60cbaedView commit details -
Regroup the code so it is better arranged
Proper describe blocks make it easier for the code to be arranged so that with and without rest tests can be incorporated into the code.
Configuration menu - View commit details
-
Copy full SHA for d066264 - Browse repository at this point
Copy the full SHA d066264View commit details -
Remove the datastore mock. It is not necessary.
Configuration menu - View commit details
-
Copy full SHA for fa5d14b - Browse repository at this point
Copy the full SHA fa5d14bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 591ce30 - Browse repository at this point
Copy the full SHA 591ce30View commit details -
Make a programmatic link to the data type so that the intent is clearer.
Configuration menu - View commit details
-
Copy full SHA for fa56366 - Browse repository at this point
Copy the full SHA fa56366View commit details -
Parameterized tests will allow us to delete half the tests. A new type is created for the test parameters.
Configuration menu - View commit details
-
Copy full SHA for 850781c - Browse repository at this point
Copy the full SHA 850781cView commit details -
Document the class for mocking datastore client
Explain the purpose of the class. This will make it useful for testing.
Configuration menu - View commit details
-
Copy full SHA for 09ee75d - Browse repository at this point
Copy the full SHA 09ee75dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 115b40a - Browse repository at this point
Copy the full SHA 115b40aView commit details -
This type is only used once so inline it.
Configuration menu - View commit details
-
Copy full SHA for 7f4a02a - Browse repository at this point
Copy the full SHA 7f4a02aView commit details -
Remove changes to system tests
Changes to system tests are not necessary. Remove them.
Configuration menu - View commit details
-
Copy full SHA for 92030db - Browse repository at this point
Copy the full SHA 92030dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a42e8c6 - Browse repository at this point
Copy the full SHA a42e8c6View commit details -
assert resolves to falsy in tests. See if this solves the issue.
Configuration menu - View commit details
-
Copy full SHA for e4bf66c - Browse repository at this point
Copy the full SHA e4bf66cView commit details
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6faca17 - Browse repository at this point
Copy the full SHA 6faca17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a0889 - Browse repository at this point
Copy the full SHA 54a0889View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2ad045 - Browse repository at this point
Copy the full SHA f2ad045View commit details -
Configuration menu - View commit details
-
Copy full SHA for b532c8d - Browse repository at this point
Copy the full SHA b532c8dView commit details -
Add comment for mocking out project id
This should allow the unit tests to pass in the continuous integration environment.
Configuration menu - View commit details
-
Copy full SHA for 2e5700a - Browse repository at this point
Copy the full SHA 2e5700aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31151be - Browse repository at this point
Copy the full SHA 31151beView commit details -
Correct title of describe block
The title of the describe block should match the file. Remove console logs too.
Configuration menu - View commit details
-
Copy full SHA for b3eda27 - Browse repository at this point
Copy the full SHA b3eda27View commit details
Commits on Dec 6, 2023
-
Change rest parameter in test to fallback
This parameter more specifically describes the change.
Configuration menu - View commit details
-
Copy full SHA for 3f97583 - Browse repository at this point
Copy the full SHA 3f97583View commit details -
Create a simple system test for using rest
This system test should show how the rest parameter is being used.
Configuration menu - View commit details
-
Copy full SHA for 09233b5 - Browse repository at this point
Copy the full SHA 09233b5View commit details -
Should check to see if entity is undefined
This allows the test to pass with a simple assertion check.
Configuration menu - View commit details
-
Copy full SHA for f009f7b - Browse repository at this point
Copy the full SHA f009f7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9a7153 - Browse repository at this point
Copy the full SHA c9a7153View commit details -
Specify fallback type instead of string | undefin
Fallback type is more specific . Use it instead.
Configuration menu - View commit details
-
Copy full SHA for b5723a0 - Browse repository at this point
Copy the full SHA b5723a0View commit details -
Merge branch 'use-http-fallback' of https://github.com/danieljbruce/n…
…odejs-datastore into use-http-fallback
Configuration menu - View commit details
-
Copy full SHA for afc8326 - Browse repository at this point
Copy the full SHA afc8326View commit details