Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): enable noImplicitAny for transaction.ts & request.ts #305

Merged
merged 36 commits into from
Feb 8, 2019
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e5744f0
Typescript Proto & Convert File
josecervino Jan 2, 2019
718fc59
TS: noImplicitAny
josecervino Jan 10, 2019
ae4d566
TS: noImplicitAny
josecervino Jan 10, 2019
e9a24e7
TS: noImplicitAny
josecervino Jan 11, 2019
e6ee910
TS: noImplicitAny
josecervino Jan 11, 2019
7a991e8
noImplicitAny: request.ts
josecervino Jan 17, 2019
b75a390
noImplicitAny: request.ts
josecervino Jan 17, 2019
a3bddfe
Merge branch 'master' of https://github.com/googleapis/nodejs-datastore
josecervino Jan 17, 2019
d709fbd
XMerge branch 'master' of https://github.com/JCIV-SE/nodejs-datastore…
josecervino Jan 17, 2019
0ac0525
noImplicitAny: request.ts
josecervino Jan 17, 2019
bc82586
Merge branch 'master' of https://github.com/googleapis/nodejs-datasto…
josecervino Jan 17, 2019
63d9bb8
Merge branch 'master' of https://github.com/googleapis/nodejs-datastore
josecervino Jan 17, 2019
3b412d2
noImplicitAny: transaction.ts
josecervino Jan 17, 2019
4ce8a38
noImplicitAny: transaction.ts interfaces minimized & imports simplified
josecervino Jan 17, 2019
151ac85
Merge branch 'master' into noImplicitAny-2
Jan 18, 2019
a6ba290
Merge branch 'master' into noImplicitAny
Jan 18, 2019
b06d692
Merge pull request #1 from JCIV-SE/noImplicitAny
Jan 18, 2019
0753f89
Merge branch 'master' into noImplicitAny-2
Jan 18, 2019
921ecf6
Merge pull request #2 from JCIV-SE/noImplicitAny-2
Jan 18, 2019
328c2bc
Transaction & Request Final
josecervino Jan 19, 2019
cdc6f75
Merge branch 'master' into noImplicitAny-converge
JustinBeckwith Jan 22, 2019
c8c5410
Official PR Revisions(#1): Request.ts
josecervino Jan 22, 2019
bba0775
Merge branch 'master' of https://github.com/googleapis/nodejs-datastore
josecervino Jan 22, 2019
29a1b0a
Merge branch 'master' of https://github.com/googleapis/nodejs-datasto…
josecervino Jan 22, 2019
50d356b
Merge branch 'noImplicitAny-converge' of https://github.com/JCIV-SE/n…
josecervino Jan 22, 2019
33bc260
Official PR Revisions(n.2): request.ts, transaction.ts, index.ts, tests
josecervino Jan 25, 2019
4ea08b9
Master Merge: conlficts resolved
josecervino Jan 25, 2019
d2f8392
Master Merge: disk conlficts resolved
josecervino Jan 25, 2019
24becae
Merge branch 'master' of https://github.com/googleapis/nodejs-datasto…
josecervino Jan 29, 2019
d3a7ee7
--transaction.ts test errors fix--
josecervino Jan 29, 2019
94ea8ad
--Line fix--
josecervino Jan 29, 2019
119ebad
Merge branch 'master' into noImplicitAny-converge
Jan 30, 2019
1d77f08
Merge branch 'master' into noImplicitAny-converge
JustinBeckwith Jan 31, 2019
20675d3
Merge branch 'master' into noImplicitAny-converge
Feb 1, 2019
5f812da
Merge branch 'master' into noImplicitAny-converge
Feb 7, 2019
8334f15
Merge branch 'master' into noImplicitAny-converge
Feb 8, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@
"clean": "gts clean",
"compile": "tsc -p . && cp -r src/v1 build/src && cp -r protos build && cp test/*.js build/test",
"prepare": "npm run compile",
"pretest": "npm run compile"
"pretest": "npm run compile",
"proto": "npm run proto:datastore",
"proto:datastore": "mkdir -p proto && pbjs -t static-module -w commonjs -p node_modules/google-proto-files google/datastore/v1/datastore.proto | pbts -o proto/datastore.d.ts -"
},
"dependencies": {
"@google-cloud/projectify": "^0.3.0",
"@google-cloud/projectify": "^0.3.2",
"@google-cloud/promisify": "^0.3.0",
"arrify": "^1.0.1",
"concat-stream": "^2.0.0",
Expand Down Expand Up @@ -68,6 +70,7 @@
"eslint-config-prettier": "^4.0.0",
"eslint-plugin-node": "^8.0.0",
"eslint-plugin-prettier": "^3.0.0",
"google-proto-files": "^0.18.0",
"gts": "^0.9.0",
"jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
"intelli-espower-loader": "^1.0.1",
Expand Down
8,865 changes: 8,865 additions & 0 deletions proto/datastore.d.ts

Large diffs are not rendered by default.

4,613 changes: 4,613 additions & 0 deletions proto/entity.d.ts

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/entity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export namespace entity {
* @type {symbol}
* @private
*/
export const KEY_SYMBOL = Symbol('KEY');
export const KEY_SYMBOL: unique symbol = Symbol('KEY');

/**
* Build a Datastore Double object. For long doubles, a string can be
Expand Down Expand Up @@ -530,7 +530,7 @@ export namespace entity {
};

if (excludeFromIndexes && excludeFromIndexes.length > 0) {
excludeFromIndexes.forEach(excludePath => {
excludeFromIndexes.forEach((excludePath: string) => {
josecervino marked this conversation as resolved.
Show resolved Hide resolved
excludePathFromEntity(entityProto, excludePath);
});
}
Expand Down
1 change: 0 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,6 @@ class Datastore extends DatastoreRequest {
static KEY = entity.KEY_SYMBOL;
KEY = Datastore.KEY;


/**
* This is one of three values which may be returned from
* {@link Datastore#runQuery}, {@link Transaction#runQuery}, and
Expand Down