Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ts): enable noImplicitAny on test/request.ts #343

Merged
merged 6 commits into from
Mar 6, 2019
Merged

refactor(ts): enable noImplicitAny on test/request.ts #343

merged 6 commits into from
Mar 6, 2019

Conversation

josecervino
Copy link

Fixes #326

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files           7        7           
  Lines         583      583           
  Branches       63       63           
=======================================
  Hits          569      569           
  Misses          6        6           
  Partials        8        8
Impacted Files Coverage Δ
src/request.ts 99.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b89e9...cfcc3d2. Read the comment docs.

src/request.ts Outdated Show resolved Hide resolved
@JustinBeckwith
Copy link
Contributor

Looks like we need a linty fixy

@JustinBeckwith JustinBeckwith merged commit 5bb02b8 into googleapis:master Mar 6, 2019
@josecervino josecervino deleted the test/request-noImplicitAny branch March 6, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants