Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.0 #71

Merged
merged 4 commits into from
Mar 19, 2018
Merged

v1.4.0 #71

merged 4 commits into from
Mar 19, 2018

Conversation

callmehiphop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         645    645           
=====================================
  Hits          645    645

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee6b83...1c3c47f. Read the comment docs.

@alexander-fenster
Copy link
Contributor

The version of datastore in samples/package.json should also be updated. Also, not sure if you did it for other packages. Samples should be linked to the current version, otherwise, samples tests will test old version from npm and will not trigger errors if anything is wrong with the current package.

@callmehiphop callmehiphop merged commit 27c5ef6 into googleapis:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants