Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes number autoconversion #941

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

fix: Fixes number autoconversion #941

wants to merge 37 commits into from

Commits on Dec 8, 2020

  1. fix: discontinue auto-conversion of JavaScript Numbers to datastore t… 

    …ypes
    @crwilcox
    crwilcox committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    28c2327 View commit details
    Browse the repository at this point in the history

  2. fix!:add a warning when a number is autoconverted to double or int

    @crwilcox
    crwilcox committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    8a5aba8 View commit details
    Browse the repository at this point in the history

  3. chore: gts fix

    @crwilcox
    crwilcox committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    068b0bf View commit details
    Browse the repository at this point in the history

  4. fix: modify warnings to be phrased better

    @crwilcox
    crwilcox committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    a7152f5 View commit details
    Browse the repository at this point in the history

  5. fix: process.once to avoid debouncing type issues

    @crwilcox
    crwilcox committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    b125553 View commit details
    Browse the repository at this point in the history

  6. fix: debounce warning of typing to occur only once

    @crwilcox
    crwilcox committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    2d31c03 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. chore: gts fix

    @crwilcox
    crwilcox committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    5b62746 View commit details
    Browse the repository at this point in the history

  2. chore: don't use it.only

    @crwilcox
    crwilcox committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    39e618c View commit details
    Browse the repository at this point in the history

  3. test: add test to verify typecast warning is debounced

    @crwilcox
    crwilcox committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    573880d View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. fix: errant console log committed

    @crwilcox
    crwilcox committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    a2ba674 View commit details
    Browse the repository at this point in the history

  2. test: alter expected properties to match property

    @crwilcox
    crwilcox committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    beab398 View commit details
    Browse the repository at this point in the history

  3. test: add test that captures current, not desired, behavior

    @crwilcox
    crwilcox committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    aa86a2f View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. feat!: do not automatically unwrap numbers for users, though allow th… 

    …em to specify it
    @crwilcox
    crwilcox committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    1d80aea View commit details
    Browse the repository at this point in the history

  2. test: modify test to capture now current wrap behavior. other tests n… 

    …eed altering still
    @crwilcox
    crwilcox committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    b2f4e4d View commit details
    Browse the repository at this point in the history

  3. feat: extend Number on Double class

    @crwilcox
    crwilcox committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    3c6eb03 View commit details
    Browse the repository at this point in the history

  4. test: fix system tests

    @crwilcox
    crwilcox committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    62f4f3e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. test: fix unit tests, revert to using number for storing value of double

    @crwilcox
    crwilcox committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    2085357 View commit details
    Browse the repository at this point in the history

  2. test: fix system test for number/double string/number change.

    @crwilcox
    crwilcox committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    b28df5f View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. tests for wrapping ints

    @danieljbruce
    danieljbruce committed May 3, 2022
    Configuration menu
    Copy the full SHA
    1713a9a View commit details
    Browse the repository at this point in the history

  2. Double values test

    @danieljbruce
    danieljbruce committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b32d3cc View commit details
    Browse the repository at this point in the history

  3. nit: clarify comment

    @danieljbruce
    danieljbruce committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5e1b0f8 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Remove dependency.

    @danieljbruce
    danieljbruce committed May 4, 2022
    Configuration menu
    Copy the full SHA
    dd9e711 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Add a test to ensure that doubles are received

    @danieljbruce
    danieljbruce committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e01fec0 View commit details
    Browse the repository at this point in the history

  2. Added more tests for Double

    @danieljbruce
    danieljbruce committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8aa7c31 View commit details
    Browse the repository at this point in the history

  3. remove repeated code fragment

    @danieljbruce
    danieljbruce committed May 5, 2022
    Configuration menu
    Copy the full SHA
    4d15a47 View commit details
    Browse the repository at this point in the history

  4. Changed warning message

    @danieljbruce
    danieljbruce committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8dc7b62 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. linting fix

    @danieljbruce
    danieljbruce committed May 6, 2022
    Configuration menu
    Copy the full SHA
    d6eff51 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/googleapis/nodejs-datastore … 

    …into fixNumberAutoconversion

# Conflicts:
#	src/v1/datastore_admin_client.ts
    @danieljbruce
    danieljbruce committed May 6, 2022
    Configuration menu
    Copy the full SHA
    70de408 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Remove file

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    074d218 View commit details
    Browse the repository at this point in the history

  2. Attempts to fix sample test

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1bf4254 View commit details
    Browse the repository at this point in the history

  3. Linting fix

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    2cdf4c5 View commit details
    Browse the repository at this point in the history

  4. Updates for sample test

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    6044901 View commit details
    Browse the repository at this point in the history

  5. Fix the datastore int constructions

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4f0c8b4 View commit details
    Browse the repository at this point in the history

  6. linting fix

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    85ae2cc View commit details
    Browse the repository at this point in the history

  7. before and after balance

    @danieljbruce
    danieljbruce committed May 9, 2022
    Configuration menu
    Copy the full SHA
    56733e7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. use deep strict equal

    @danieljbruce
    danieljbruce committed May 10, 2022
    Configuration menu
    Copy the full SHA
    80b993b View commit details
    Browse the repository at this point in the history

  2. Fix sample

    @danieljbruce
    danieljbruce committed May 10, 2022
    Configuration menu
    Copy the full SHA
    9371dcb View commit details
    Browse the repository at this point in the history