Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

DO NOT MERGE: updating generated code to v2beta2, releasing v0.3.0 #16

Closed
wants to merge 17 commits into from
Closed

DO NOT MERGE: updating generated code to v2beta2, releasing v0.3.0 #16

wants to merge 17 commits into from

Conversation

alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Jan 9, 2018 •
edited
Loading

Most samples test still fail. Please do not merge until approved by @neozwu.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2018
@codecov
Copy link

codecov bot commented Jan 9, 2018 •
edited
Loading

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      5    +1     
=====================================
+ Hits            4      5    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f1c72...55a5ea9. Read the comment docs.

@alexander-fenster alexander-fenster removed the request for review from ace-n January 9, 2018 23:51
@alexander-fenster alexander-fenster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 30, 2018
@stephenplusplus stephenplusplus added the status: blocked Resolving the issue is dependent on other work. label Feb 5, 2018
@ghost ghost assigned ace-n Feb 23, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 23, 2018
@alexander-fenster
Copy link
Contributor Author

Closing as #23 will be merged instead.

@ghost ghost removed the status: blocked Resolving the issue is dependent on other work. label Mar 15, 2018
@stephenplusplus stephenplusplus deleted the update-dlp-v2beta2 branch March 21, 2018 03:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees

@ace-n ace-n

@alexander-fenster alexander-fenster

Labels
cla: no This human has *not* signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexander-fenster @googlebot @stephenplusplus @ace-n