Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Commit

Permalink
chore!: upgrade to Node 14 (#556)
Browse files Browse the repository at this point in the history
* docs: fix node release schedule link

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Link: googleapis/synthtool@1a24315
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430

* chore!: upgrade to Node 14

* run lint

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Sofia Leon <sofialeon@google.com>
  • Loading branch information
3 people committed Aug 10, 2023
1 parent 383c0d7 commit 75b5a56
Show file tree
Hide file tree
Showing 23 changed files with 26 additions and 27 deletions.
4 changes: 2 additions & 2 deletions .github/.OwlBot.lock.yaml
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
digest: sha256:0527a86c10b67742c409dc726ba9a31ec4e69b0006e3d7a49b0e6686c59cdaa9
# created: 2023-05-24T20:32:43.844586914Z
digest: sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430
# created: 2023-08-03T18:46:14.719706948Z
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (12)
- test (14)
- test (16)
- test (18)
- cla/google
- windows
- OwlBot Post Processor
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16]
node: [14, 16, 18, 20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
File renamed without changes.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
2 changes: 1 addition & 1 deletion .kokoro/release/docs.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/release/publish.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -91,7 +91,7 @@ also contains samples.

## Supported Node.js Versions

Our client libraries follow the [Node.js release schedule](https://nodejs.org/en/about/releases/).
Our client libraries follow the [Node.js release schedule](https://github.com/nodejs/release#release-schedule).
Libraries are compatible with all current _active_ and _maintenance_ versions of
Node.js.
If you are using an end-of-life version of Node.js, we recommend that you update
Expand Down
16 changes: 8 additions & 8 deletions package.json
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
},
"repository": "googleapis/nodejs-dns",
"main": "./build/src/index.js",
Expand Down Expand Up @@ -44,9 +44,9 @@
"precompile": "gts clean"
},
"dependencies": {
"@google-cloud/common": "^4.0.0",
"@google-cloud/paginator": "^4.0.0",
"@google-cloud/promisify": "^3.0.0",
"@google-cloud/common": "^5.0.0",
"@google-cloud/paginator": "^5.0.0",
"@google-cloud/promisify": "^4.0.0",
"arrify": "^2.0.0",
"dns-zonefile": "0.2.10",
"lodash.groupby": "^4.6.0",
Expand All @@ -55,22 +55,22 @@
"devDependencies": {
"@types/lodash.groupby": "^4.6.4",
"@types/mocha": "^9.0.0",
"@types/node": "^18.0.0",
"@types/node": "^20.4.9",
"@types/proxyquire": "^1.3.28",
"@types/request": "^2.48.1",
"@types/tmp": "0.2.3",
"@types/uuid": "^9.0.0",
"c8": "^8.0.0",
"c8": "^8.0.1",
"codecov": "^3.0.2",
"gts": "^3.0.0",
"gts": "^5.0.0",
"jsdoc": "^4.0.0",
"jsdoc-fresh": "^2.0.0",
"jsdoc-region-tag": "^2.0.0",
"linkinator": "^4.0.0",
"mocha": "^9.2.2",
"proxyquire": "^2.0.1",
"tmp": "^0.2.0",
"typescript": "^4.6.4",
"typescript": "^5.1.6",
"uuid": "^9.0.0"
}
}
2 changes: 1 addition & 1 deletion samples/package.json
Expand Up @@ -5,7 +5,7 @@
"author": "Google Inc.",
"repository": "googleapis/nodejs-dns",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
},
"files": [
"*.js",
Expand Down
7 changes: 3 additions & 4 deletions src/zone.ts
Expand Up @@ -183,10 +183,9 @@ type Without<T, K> = {

// Using the Without type, we essentially make a new ServiceObject type that
// doesn't contain any of the methods that have signatures we wish to override.
type ZoneServiceObject = new (config: ServiceObjectConfig) => Without<
ServiceObject<Zone>,
'create' | 'delete' | 'get'
>;
type ZoneServiceObject = new (
config: ServiceObjectConfig
) => Without<ServiceObject<Zone>, 'create' | 'delete' | 'get'>;

// This is used purely for making TypeScript think that the object we are
// subclassing does not contain a signature mismatch for methods we are
Expand Down

0 comments on commit 75b5a56

Please sign in to comment.