Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

build!: update to latest version of gts and typescript #376

Merged
merged 8 commits into from
Apr 13, 2020
Merged

build!: update to latest version of gts and typescript #376

merged 8 commits into from
Apr 13, 2020

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Apr 9, 2020

No description provided.

@sofisl sofisl requested a review from bcoe April 9, 2020 23:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2020
@sofisl
Copy link
Contributor Author

sofisl commented Apr 10, 2020

I used this PR as reference for the rest-params usage: https://github.com/googleapis/nodejs-bigtable/pull/682/files

@codecov
Copy link

codecov bot commented Apr 10, 2020 •
edited
Loading

Codecov Report

Merging #376 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files           4        4           
  Lines        2282     2285    +3     
  Branches       94       94           
=======================================
+ Hits         2254     2257    +3     
  Misses         26       26           
  Partials        2        2
Impacted Files Coverage Δ
src/record.ts 99.56% <100.00%> (+<0.01%) ⬆️
src/zone.ts 98.16% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8b083...e3dbbc0. Read the comment docs.

@JustinBeckwith JustinBeckwith added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

3 similar comments
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c35b94e into master Apr 13, 2020
@release-please release-please bot mentioned this pull request Apr 13, 2020
Merged
yoshi-automation added a commit that referenced this pull request Apr 13, 2020
@yoshi-automation
build!: update to latest version of gts and typescript (#376)
1362c58 
Source-Repo: googleapis/nodejs-dns
Source-Sha: c35b94e
Source-Link: c35b94e
Author: sofisl <55454395+sofisl@users.noreply.github.com>
Date: Sun Apr 12 17:28:06 2020 -0700
Original-Commit-Message: build!: update to latest version of gts and typescript (#376)
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 16, 2020
@release-please
chore: release 2.0.0 (#375)
c7381ca 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/nodejs-dns/compare/v1.2.9...v2.0.0) (2020-04-14)


### ⚠ BREAKING CHANGES

* update to latest version of gts and typescript (#376)
* require node 10 in engines field (#374)

### Features

* require node 10 in engines field ([#374](https://www.github.com/googleapis/nodejs-dns/issues/374)) ([aba0475](https://www.github.com/googleapis/nodejs-dns/commit/aba047555b12b8c6a243581fc65579381d497b1f))


### Bug Fixes

* apache license URL ([#468](https://www.github.com/googleapis/nodejs-dns/issues/468)) ([#372](https://www.github.com/googleapis/nodejs-dns/issues/372)) ([32e13a1](https://www.github.com/googleapis/nodejs-dns/commit/32e13a10bdcbea7abaa25add7cb133e5bf854c60))
* **deps:** update dependency @google-cloud/common to v3 ([#367](https://www.github.com/googleapis/nodejs-dns/issues/367)) ([3d8b083](https://www.github.com/googleapis/nodejs-dns/commit/3d8b08380e56dfb62d7b596fde9624119d08b4ec))
* **deps:** update dependency @google-cloud/paginator to v3 ([#365](https://www.github.com/googleapis/nodejs-dns/issues/365)) ([25ea868](https://www.github.com/googleapis/nodejs-dns/commit/25ea86858f27afbcda7bf8370ac742d0a8abbcb6))
* **deps:** update dependency @google-cloud/promisify to v2 ([#364](https://www.github.com/googleapis/nodejs-dns/issues/364)) ([2f732bf](https://www.github.com/googleapis/nodejs-dns/commit/2f732bf6fdc44c0f7c471126935ddb62cba5fbd3))


### Build System

* update to latest version of gts and typescript ([#376](https://www.github.com/googleapis/nodejs-dns/issues/376)) ([c35b94e](https://www.github.com/googleapis/nodejs-dns/commit/c35b94e4a49c5d2644aa64fe4ad85b2de4002e01))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sofisl @JustinBeckwith @googlebot @yoshi-kokoro