-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup types for reportManualError #310
Conversation
src/interfaces/manual.ts
Outdated
@@ -16,6 +16,7 @@ | |||
|
|||
import * as http from 'http'; | |||
import * as is from 'is'; | |||
import {any} from 'joi'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's that do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shakes fist VSCode!
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 34 34
Lines 1687 1687
Branches 76 76
=======================================
Hits 1621 1621
Misses 49 49
Partials 17 17
Continue to review full report at Codecov.
|
I could go either way with the semver major-ness. Do you think there are going to be other changes you want to bundle? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ nit - your call on the semverness
Fixes: #35
I'm debating if this is semver major for typescript users.