-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DocumentSnapshot support for Cursors #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1601 1642 +41
=====================================
+ Hits 1601 1642 +41
Continue to review full report at Codecov.
|
6cb95f6
to
6ef7760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern, but otherwise looks good!
src/reference.js
Outdated
|
||
this._fieldOrders.push( | ||
new FieldOrder(FieldPath.documentId(), lastDirection) | ||
); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ab2bb18
to
b5beba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good.
Adds support for DocumentSnapshots in the Query Cursor API. Related: #98