Allow Protobuf arrays with unset values #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
cla: yes
schmidt-sebastian
changed the title
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1642 1644 +2
=====================================
+ Hits 1642 1644 +2
Continue to review full report at Codecov.
|
stephenplusplus
approved these changes
Jan 12, 2018
ghost
removed
the
cla: yes
schmidt-sebastian
added a commit
that referenced
this pull request
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Firebase Functions sometimes send us an Array protobuf that is missing the
valuesfield altogether, which results in an undefined iterator error.Fixes #103