Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to specify custom headers for individual RPC types #1355

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This makes it possible to specify custom headers for a single RPC type as such:

 firestore = new Firestore({commit: {customHeaders: {'X-Header: 'Value'}}});

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Nov 4, 2020
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/customheaders branch 2 times, most recently from f803138 to db71bc1 Compare November 4, 2020 21:02
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1355 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1355   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          32       32           
  Lines       19290    19291    +1     
  Branches     1387     1388    +1     
=======================================
+ Hits        19011    19012    +1     
  Misses        276      276           
  Partials        3        3           
Impacted Files Coverage Δ
dev/src/index.ts 97.52% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7223281...7bc887e. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice, but can understand wanting to get this out to test.

@schmidt-sebastian schmidt-sebastian merged commit 0900379 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants