Allow npm publish to use tsc
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
googlebot
added
the
cla: yes
schmidt-sebastian
changed the base branch from
schmidt-sebastian-patch-1
to
master
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2135 2135
Branches 460 460
=====================================
Hits 2135 2135Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM publish needs to install the typescript dependency to be able to publish.
See https://circleci.com/gh/googleapis/nodejs-firestore/7128