Remove unhandled Promise rejection warning #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 24 24
Lines 1931 1931
Branches 168 168
=======================================
Hits 1851 1851
Misses 57 57
Partials 23 23Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #553, I added type information to
DeferredPromise. As part of this, I changed the initialization in the constructor toPromise.reject()since I no longer know the value type. Turns out that that logs a bunch of "unhandled promise rejection" warnings. This PR makes the Promise nullable and defers the initialization. It's not the cleanest solution, but it's test-only code that isn't reused...