Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): use node10 for system-test and samples-test #571

Merged
merged 1 commit into from
Mar 6, 2019
Merged

build(ci): use node10 for system-test and samples-test #571

merged 1 commit into from
Mar 6, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Mar 6, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2019
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          24       24           
  Lines        1943     1943           
  Branches      168      168           
=======================================
  Hits         1861     1861           
  Misses         59       59           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04eb91c...c85ede3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 6, 2019 •
edited
Loading

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          24       24           
  Lines        1943     1943           
  Branches      168      168           
=======================================
  Hits         1861     1861           
  Misses         59       59           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04eb91c...c85ede3. Read the comment docs.

@alexander-fenster alexander-fenster merged commit 1b6c7b1 into master Mar 6, 2019
@alexander-fenster alexander-fenster deleted the node-10-ci branch March 6, 2019 23:23
schmidt-sebastian pushed a commit that referenced this pull request Mar 11, 2019
@jkwlui @schmidt-sebastian
build: use node10 to run samples-test, system-test etc (#571)
3b25b78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkwlui @JustinBeckwith @alexander-fenster @googlebot