Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow Node 10 on presubmit to push to codecov #612

Merged
merged 4 commits into from May 7, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 6, 2019

allow Node 10 on presubmit to push to codecov

@bcoe bcoe requested a review from jkwlui May 6, 2019 23:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2019
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #612 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   61.09%   61.18%   +0.08%     
==========================================
  Files          21       21              
  Lines        3375     3375              
  Branches      453      453              
==========================================
+ Hits         2062     2065       +3     
+ Misses       1252     1250       -2     
+ Partials       61       60       -1
Impacted Files Coverage Δ
dev/src/watch.ts 97.67% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cecce3...1155aa7. Read the comment docs.

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #612 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   61.09%   61.09%           
=======================================
  Files          21       21           
  Lines        3375     3375           
  Branches      453      453           
=======================================
  Hits         2062     2062           
  Misses       1252     1252           
  Partials       61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181a934...c37f69b. Read the comment docs.

@callmehiphop callmehiphop added the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2019
@bcoe bcoe merged commit c119250 into master May 7, 2019
@bcoe bcoe deleted the node-10-codecov-presubmit branch May 7, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants