Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add IN queries support #715

Merged
merged 11 commits into from Nov 1, 2019
Merged

feat: add IN queries support #715

merged 11 commits into from Nov 1, 2019

Conversation

thebrianchen
Copy link

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2019
merlinnot
merlinnot reviewed Jul 9, 2019
View reviewed changes
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
@thebrianchen thebrianchen changed the title feat: Add IN queries support feat: Add IN queries support (blocked) Jul 9, 2019
@thebrianchen thebrianchen added the status: blocked Resolving the issue is dependent on other work. label Jul 9, 2019
@merlinnot
Update dev/src/reference.ts
d42f2ae 
Co-Authored-By: Natan Sągol <m@merlinnot.com>
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #715 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   96.05%   96.09%   +0.04%     
==========================================
  Files          20       20              
  Lines        2228     2228              
  Branches      472      472              
==========================================
+ Hits         2140     2141       +1     
  Misses         22       22              
+ Partials       66       65       -1
Impacted Files Coverage Δ
dev/src/types.ts 100% <ø> (ø) ⬆️
dev/src/reference.ts 99.01% <ø> (ø) ⬆️
dev/src/serializer.ts 94.48% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a438aa8...d42f2ae. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 9, 2019 •
edited

Codecov Report

Merging #715 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   74.19%   74.22%   +0.03%     
==========================================
  Files          50       50              
  Lines        2914     2914              
  Branches      467      467              
==========================================
+ Hits         2162     2163       +1     
  Misses        697      697              
+ Partials       55       54       -1
Impacted Files Coverage Δ
dev/src/types.ts 100% <ø> (ø) ⬆️
dev/src/reference.ts 99.03% <ø> (ø) ⬆️
dev/src/serializer.ts 96.8% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6568a47...6d9574a. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 9, 2019
@merlinnot
Update dev/src/reference.ts
9c714fd 
Co-Authored-By: Natan Sągol <m@merlinnot.com>
@thebrianchen thebrianchen added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@thebrianchen thebrianchen added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. cla: yes This human has signed the Contributor License Agreement. labels Jul 9, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

schmidt-sebastian
schmidt-sebastian reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much what we need. The only thing missing is the backend rollout :)

dev/protos/firestore_proto_api.d.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Show resolved Hide resolved
@thebrianchen thebrianchen added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 10, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@thebrianchen thebrianchen removed their assignment Jul 10, 2019
schmidt-sebastian
schmidt-sebastian reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dev/system-test/firestore.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
@schmidt-sebastian schmidt-sebastian mentioned this pull request Jul 23, 2019
Merged
@hadyrashwan
Copy link

Any news when this feature will be rolled out ?? Is it 2019 ??

@schmidt-sebastian
Copy link
Contributor

@hadyrashwan We generally don't comment on release dates. Sorry!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@thebrianchen thebrianchen changed the title feat: Add IN queries support (blocked) feat: add IN queries support (blocked) Oct 17, 2019
@thebrianchen thebrianchen reopened this Oct 17, 2019
@BenWhitehead BenWhitehead mentioned this pull request Oct 25, 2019
Closed
schmidt-sebastian
schmidt-sebastian approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please hold off on merging until end of week.

@schmidt-sebastian schmidt-sebastian removed their assignment Oct 28, 2019
@thebrianchen thebrianchen changed the title feat: add IN queries support (blocked) feat: add IN queries support Nov 1, 2019
@thebrianchen thebrianchen removed the status: blocked Resolving the issue is dependent on other work. label Nov 1, 2019
@schmidt-sebastian schmidt-sebastian merged commit 00bdf8f into master Nov 1, 2019
@schmidt-sebastian schmidt-sebastian deleted the bc/in-queries branch November 1, 2019 17:42
@quartzmo quartzmo mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlinnot merlinnot merlinnot left review comments

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thebrianchen @googlebot @hadyrashwan @schmidt-sebastian @merlinnot