-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close GRPC channel when we dispose of clients #779
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
31609e9
Call GrpcClient.close() when we dispose of clients
schmidt-sebastian 21f773f
feat!: convert to TypeScript
alexander-fenster f01a8d3
fix: make conformance test pass (#809)
schmidt-sebastian 2f43d5c
refactor: split proto files (#810)
schmidt-sebastian 790fe98
Merge branch 'master' into typescript
schmidt-sebastian 67ce1e6
fix: add license to generated protos (#816)
schmidt-sebastian 8426686
Use LLC license
schmidt-sebastian 2421912
re-run synthtool, update google-gax
schmidt-sebastian 0e499aa
Update all dependencies
schmidt-sebastian 28e56a4
Re-run prettier
schmidt-sebastian 7a0d5ed
Merge
schmidt-sebastian 3c450c7
Update to use Promises
schmidt-sebastian 9e01b87
Add comment
schmidt-sebastian 9b44ce0
Merge branch 'master' into mrschmidt/shutdown
schmidt-sebastian b1067a0
Temporarily set timeout to 60000
schmidt-sebastian 9508a1c
Merge branch 'mrschmidt/shutdown' of github.com:googleapis/nodejs-fir…
schmidt-sebastian 8fc4355
CI
schmidt-sebastian 77c66e5
Fix potential race
schmidt-sebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm - do we really have
.close()
? :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet - but this PR shows how we could add it. We still have to add it to the Gapic generator though (if you are okay with the general direction).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-fenster Do you know what the next sets of steps would be if we wanted to add this support?