Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update terminate test to not be racey #833

Closed
wants to merge 10 commits into from

Conversation

thebrianchen
Copy link

Is this more along the lines of what you're talking about? Realized there's not really a need for the snapshot listener, since it was just a manual check to make sure nothing errored out.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2019
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #833 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          25       25           
  Lines        2828     2828           
  Branches      708      708           
=======================================
  Hits         2553     2553           
  Misses        122      122           
  Partials      153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93c77d...9b089cd. Read the comment docs.

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but since you now only have one entry and exit point you could use a Promise again (as long as you return it to the calling scope). Up to you.

@thebrianchen
Copy link
Author

Closing since it's already being implemented in #845.

@schmidt-sebastian schmidt-sebastian deleted the bc/terminate-test-fix branch January 15, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants