New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update terminate test to not be racey #833
Conversation
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 25 25
Lines 2828 2828
Branches 708 708
=======================================
Hits 2553 2553
Misses 122 122
Partials 153 153 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but since you now only have one entry and exit point you could use a Promise again (as long as you return it to the calling scope). Up to you.
Closing since it's already being implemented in #845. |
Is this more along the lines of what you're talking about? Realized there's not really a need for the snapshot listener, since it was just a manual check to make sure nothing errored out.