refactor: remove usage of 'self' #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt/self
branch
from
4d4082e
to
850fc6c
Compare
schmidt-sebastian
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
=========================================
- Coverage 96.6% 96.6% -0.01%
=========================================
Files 25 25
Lines 15541 15539 -2
Branches 1151 1151
=========================================
- Hits 15013 15011 -2
Misses 519 519
Partials 9 9
Continue to review full report at Codecov.
|
thebrianchen
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
I think there's one more instance of self = this here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.