Cleanup #94
Cleanup #94
Conversation
googlebot
added
the
cla: yes
src/document.js
Outdated
| @@ -576,8 +576,9 @@ class DocumentSnapshot { | |||
| * @return {boolean} | |||
| */ | |||
| get isEmpty() { | |||
| return !this._fieldsProto || isEmptyObject(this._fieldsProto); | |||
| return this._fieldsProto === undefined || isEmptyObject(this._fieldsProto); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/document.js
Outdated
| @@ -652,7 +650,6 @@ class DocumentSnapshot { | |||
|
|
|||
| /** | |||
| * Encodes a JavaScrip value into the Firestore 'Value' representation. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1599 1593 -6
=====================================
- Hits 1599 1593 -6
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
mrschmidt-argumentcleanup
branch
from
4ade7e4
to
63f7a28
Compare
|
Linting failed :( Probably another case of your local copy pulling from npm’s cache. |
Yes, I still don't quite know where that is coming from. I continued on some other PRs as well that have the same errors which I will send out shortly. When I finally figure out the root cause, I'll update them all in one go. |
|
I'll just approve so you're good to merge whenever linting stops being a downer. |
|
Whaaaa.... Updating |
ghost
removed
the
cla: yes
This is just a bit of cleanup from migrating this code to Java.
The "big" change in here is that _fieldsProto is now {} instead of
nullfor empty documents.