This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: add new samples, update linters #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Ping @bcoe |
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
===========================================
- Coverage 98.37% 70.18% -28.19%
===========================================
Files 3 34 +31
Lines 3681 5876 +2195
Branches 133 27 -106
===========================================
+ Hits 3621 4124 +503
- Misses 59 1752 +1693
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
|
I'm not really sure how to make the linter happy? It seems to be complaining about the generated TypeScript files. |
bcoe
suggested changes
Apr 28, 2020
There was a problem hiding this comment.
Samples look great 👌
With regards to the linter updates, this should all be managed automatically by our code generation. Mind coordinating with @alexander-fenster, and figuring out why some of these changes were needed in this PR (since he was the one who migrated this repository to the new version of the gts linter).
bcoe
approved these changes
Apr 28, 2020
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Fills in missing samples and updates existing samples to the new format. This also updates the linter to match newer repos like Secret Manager.
bcoe
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills in missing samples and updates existing samples to the new format. This also updates the linter to match newer repos like Secret Manager.