-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
Ping @bcoe |
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
===========================================
- Coverage 98.37% 70.18% -28.19%
===========================================
Files 3 34 +31
Lines 3681 5876 +2195
Branches 133 27 -106
===========================================
+ Hits 3621 4124 +503
- Misses 59 1752 +1693
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
I'm not really sure how to make the linter happy? It seems to be complaining about the generated TypeScript files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Samples look great 👌
With regards to the linter updates, this should all be managed automatically by our code generation. Mind coordinating with @alexander-fenster, and figuring out why some of these changes were needed in this PR (since he was the one who migrated this repository to the new version of the gts linter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I can take over and push the PR that ignores the docs test temporarily, and get this landed.
Fills in missing samples and updates existing samples to the new format. This also updates the linter to match newer repos like Secret Manager.
Fills in missing samples and updates existing samples to the new format. This also updates the linter to match newer repos like Secret Manager.