Skip to content

Commit

Permalink
chore!: upgrade to Node 14 (#705)
Browse files Browse the repository at this point in the history
* docs: fix node release schedule link

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Link: googleapis/synthtool@1a24315
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore!: upgrade to Node 14


* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Sofia Leon <sofialeon@google.com>
  • Loading branch information
3 people committed Aug 10, 2023
1 parent e36a09f commit e2299d6
Show file tree
Hide file tree
Showing 15 changed files with 17 additions and 257 deletions.
4 changes: 2 additions & 2 deletions .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest
digest: sha256:ef104a520c849ffde60495342ecf099dfb6256eab0fbd173228f447bc73d1aa9
# created: 2023-07-10T21:36:52.433664553Z
digest: sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430
# created: 2023-08-03T18:46:14.719706948Z
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16, 18]
node: [14, 16, 18, 20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
164 changes: 0 additions & 164 deletions .kokoro/continuous/node12/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node12/lint.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node12/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/continuous/node12/system-test.cfg

This file was deleted.

Empty file removed .kokoro/continuous/node12/test.cfg
Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node12/common.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node12/samples-test.cfg

This file was deleted.

12 changes: 0 additions & 12 deletions .kokoro/presubmit/node12/system-test.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node12/test.cfg
Empty file.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ also contains samples.

## Supported Node.js Versions

Our client libraries follow the [Node.js release schedule](https://nodejs.org/en/about/releases/).
Our client libraries follow the [Node.js release schedule](https://github.com/nodejs/release#release-schedule).
Libraries are compatible with all current _active_ and _maintenance_ versions of
Node.js.
If you are using an end-of-life version of Node.js, we recommend that you update
Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
},
"repository": "googleapis/nodejs-logging-bunyan",
"main": "./build/src/index.js",
Expand Down Expand Up @@ -52,31 +52,31 @@
},
"dependencies": {
"@google-cloud/logging": "^10.2.2",
"google-auth-library": "^8.0.2"
"google-auth-library": "^9.0.0"
},
"devDependencies": {
"@google-cloud/common": "^4.0.0",
"@google-cloud/common": "^5.0.0",
"@types/bunyan": "^1.8.4",
"@types/express": "^4.16.0",
"@types/mocha": "^9.0.0",
"@types/node": "^18.0.0",
"@types/node": "^20.4.9",
"@types/proxyquire": "^1.3.28",
"@types/uuid": "^9.0.0",
"bunyan": "^1.8.12",
"c8": "^8.0.0",
"c8": "^8.0.1",
"codecov": "^3.0.2",
"cpy-cli": "^4.0.0",
"delay": "^5.0.0",
"express": "^4.16.3",
"gts": "^3.1.0",
"gts": "^5.0.0",
"jsdoc": "^4.0.0",
"jsdoc-fresh": "^2.0.0",
"jsdoc-region-tag": "^2.0.0",
"linkinator": "^5.0.0",
"mocha": "^9.2.2",
"post-install-check": "0.0.1",
"proxyquire": "^2.0.1",
"typescript": "^4.6.4",
"typescript": "^5.1.6",
"uuid": "^9.0.0"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions samples/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Google Inc.",
"repository": "googleapis/nodejs-logging-bunyan",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
},
"scripts": {
"test": "mocha system-test --timeout 600000"
Expand All @@ -27,4 +27,4 @@
"got": "^11.0.0",
"mocha": "^8.0.0"
}
}
}
8 changes: 4 additions & 4 deletions system-test/logging-bunyan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ describe('LoggingBunyan', function () {
level: 'error',
verify: (entry: types.StackdriverEntry) => {
assert(
(
(entry.data as types.StackdriverData).message as string
).startsWith('Error: second')
((entry.data as types.StackdriverData).message as string).includes(
'Error: second'
)
);
assert.strictEqual(
(entry.data as types.StackdriverData).pid,
Expand Down Expand Up @@ -252,7 +252,7 @@ describe('LoggingBunyan', function () {
const errEvent = errors[0];

assert.strictEqual(errEvent.serviceContext.service, SERVICE);
assert(errEvent.message.startsWith(`Error: ${message}`));
assert(errEvent.message.includes(`Error: ${message}`));
});
});
});
Expand Down

0 comments on commit e2299d6

Please sign in to comment.