Logging Bunyan Typescript Migration #15

gaofanmichael · 2017-11-27T19:10:10Z

Tests and linter pass
Tests/sample tests/system tests all migrated.

package.json

@@ -8,7 +8,7 @@
    "node": ">=4.0.0"
  },
  "repository": "googleapis/nodejs-logging-bunyan",
-  "main": "./src/index.js",
+  "main": "./build/src/index.js",


package.json

@@ -8,7 +8,7 @@
    "node": ">=4.0.0"
  },
  "repository": "googleapis/nodejs-logging-bunyan",
-  "main": "./src/index.js",
+  "main": "./build/src/index.js",


package.json

-    "extend": "^3.0.1"
+    "@types/bunyan": "^1.8.3",
+    "extend": "^3.0.1",
+    "stream": "0.0.2",


package.json

+    "@types/bunyan": "^1.8.3",
+    "extend": "^3.0.1",
+    "stream": "0.0.2",
+    "typescript": "^2.6.1"


src/index.ts

+import * as util from 'util';
+import {Writable} from 'stream';
+const logging = require('@google-cloud/logging');
+// var Writable = require('stream').Writable;


src/index.ts

+   *
+   * @private
+   */
+  _write(record: BunyanLogRecord, encoding?: string, callback?: Function) {


src/index.ts

+      }>,
+      callback?: Function) {
+    // tslint:disable-next-line:no-any
+    const entries = chunks.map((request: any) => {


system-test/logging-bunyan.ts

+ * limitations under the License.
+ */
+
+'use strict';


test/index.ts

+ * limitations under the License.
+ */
+import * as assert from 'assert';
+import * as extend from 'extend';


tsconfig.json

+    "outDir": "build",
+    "skipLibCheck": true,
+    "noStrictGenericChecks": true,
+    "strictFunctionTypes": false


src/index.ts

+import * as extend from 'extend';
+import * as util from 'util';
+import {Writable} from 'stream';
+const logging = require('@google-cloud/logging');


src/index.ts

+// var Writable = require('stream').Writable;
+
+// Map of Stackdriver logging levels.
+const BUNYAN_TO_STACKDRIVER: {[key: number]: string} = {


src/index.ts

@@ -0,0 +1,257 @@
+/*!


src/index.ts

+  private stackdriverLog:
+      StackdriverLog;  // TODO: add type for @google-cloud/logging
+  constructor(options: Options) {
+    if (new.target !== LoggingBunyan) {


src/index.ts

+  }
+
+  /**
+   * @param {string|number} level A bunyan logging level. Log entries at or


src/index.ts

+   *
+   * @param {object} record - Bunyan log record.
+   *
+   * @private


src/index.ts

+   */
+  // Writable.write used 'any' in function signature.
+  // tslint:disable-next-line:no-any
+  write(record: any, callback?: Function): boolean;


package.json

@@ -8,9 +8,11 @@
    "node": ">=4.0.0"
  },
  "repository": "googleapis/nodejs-logging-bunyan",
-  "main": "./src/index.js",
+  "main": "./build/src/index.js",
+  "types": "./build/src/index.d.ts",
  "files": [
    "src",


gaofanmichael added 5 commits November 21, 2017 17:17

chore: Migrated Bunyan source to typescript

d90b5dc

Migrated tests

c8ca091

work on system-test

b34f517

Lint Config

31a67d3

Fixed system test

58aa6e7

ghost assigned gaofanmichael Nov 27, 2017

ghost added cla: yes This human has signed the Contributor License Agreement. in progress labels Nov 27, 2017

fixed CI failure

9ad25d9

gaofanmichael requested review from ofrobots and jinwoo November 27, 2017 19:53

JustinBeckwith suggested changes Nov 27, 2017

View reviewed changes

jinwoo reviewed Nov 27, 2017

View reviewed changes

gaofanmichael force-pushed the typescript branch 2 times, most recently from 340573a to 17b51d2 Compare November 28, 2017 01:27

Respond comments

2a1e324

gaofanmichael force-pushed the typescript branch from 17b51d2 to 2a1e324 Compare November 28, 2017 01:41

JustinBeckwith reviewed Nov 28, 2017

View reviewed changes

package.json Outdated

@@ -8,9 +8,11 @@

"node": ">=4.0.0"

},

"repository": "googleapis/nodejs-logging-bunyan",

"main": "./src/index.js",

"main": "./build/src/index.js",

"types": "./build/src/index.d.ts",

"files": [

"src",

This comment was marked as spam.

Sign in to view

JustinBeckwith approved these changes Nov 28, 2017

View reviewed changes

fix test failure

abf790b

gaofanmichael force-pushed the typescript branch from b902924 to abf790b Compare November 28, 2017 17:22

gaofanmichael merged commit cb3de89 into googleapis:typescript Nov 28, 2017

gaofanmichael deleted the typescript branch November 28, 2017 20:32

jmdobry removed the in progress label Nov 28, 2017

lukesneeringer added in progress and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 28, 2017

Logging Bunyan Typescript Migration #15

Logging Bunyan Typescript Migration #15

Conversation

gaofanmichael commented Nov 27, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.