Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Switch instrumentation code to return version stored in NODEJS_BUNYAN_DEFAULT_LIBRARY_VERSION #672

Merged
merged 4 commits into from
Nov 7, 2022
Merged

fix: Switch instrumentation code to return version stored in NODEJS_BUNYAN_DEFAULT_LIBRARY_VERSION #672

merged 4 commits into from
Nov 7, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Nov 4, 2022

Fixes #669 🦕

@losalex losalex requested review from a team as code owners November 4, 2022 23:18
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 4, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Nov 4, 2022
daniel-sanche
daniel-sanche approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it would be great if you could add a comment explaining that this variable is controlled by release-please

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2022
@losalex losalex merged commit 2eb88d8 into main Nov 7, 2022
@losalex losalex deleted the losalex/fix-switch-annotations branch November 7, 2022 19:51
@release-please release-please bot mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@losalex @daniel-sanche @yoshi-kokoro