-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3102:nodejs-logging-winston: Convert samples test from ava to mocha #207
3102:nodejs-logging-winston: Convert samples test from ava to mocha #207
Conversation
Thank you for opening this PR. For completeness, can you please provide a short summary of why this change is needed for those that don't want to log in to view the link you referenced. Thanks. |
@DominicKramer this is part of a broad effort to use mocha consistently for all of our tests. This is mine :) |
@JustinBeckwith sounds good 👍 |
@DominicKramer Thank you for suggestion I will add the description. |
After the system tests are passing, I'm happy to merge! |
Hi @JustinBeckwith, Sorry for late reply. Further when I execute command 'npm run system-test'. I am able to see two test cases are passed successfully that is shown failed in log file and rest required "Stackdriver Error Reporting API has not been used in project 980770916211 before or it is disabled" and my account still not have credentials to enable it. Here is output file attached after running system test from my local window system using nodejs v8.11.3 and please let me know your feedback. |
I think the system test errors are independent of this PR. PR #212 fixes part of the system system tests. I am also working on another PR that fixes the installation tests. When those land, and you rebase, the system tests should pass on this PR. |
Fixes convert all sample tests from ava to mocha #2865(googleapis/google-cloud-node#2865) (it's a good idea to open an issue first for discussion)