Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3102:nodejs-logging-winston: Convert samples test from ava to mocha #207

Merged
merged 4 commits into from
Nov 12, 2018

Conversation

nareshqlogic
Copy link
Contributor

@nareshqlogic nareshqlogic commented Oct 30, 2018

Fixes convert all sample tests from ava to mocha #2865(googleapis/google-cloud-node#2865) (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@DominicKramer
Copy link
Contributor

Thank you for opening this PR. For completeness, can you please provide a short summary of why this change is needed for those that don't want to log in to view the link you referenced. Thanks.

@JustinBeckwith
Copy link
Contributor

@DominicKramer this is part of a broad effort to use mocha consistently for all of our tests. This is mine :)

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2018
@DominicKramer
Copy link
Contributor

@JustinBeckwith sounds good 👍

@nareshqlogic
Copy link
Contributor Author

@DominicKramer Thank you for suggestion I will add the description.

@JustinBeckwith
Copy link
Contributor

After the system tests are passing, I'm happy to merge!

@nareshqlogic
Copy link
Contributor Author

Hi @JustinBeckwith,

Sorry for late reply.
Should we required to pass successfully system-test? as we are working on converting samples test from ava to mocha. Let me correct if I am wrong.

Further when I execute command 'npm run system-test'. I am able to see two test cases are passed successfully that is shown failed in log file and rest required "Stackdriver Error Reporting API has not been used in project 980770916211 before or it is disabled" and my account still not have credentials to enable it. Here is output file attached after running system test from my local window system using nodejs v8.11.3 and please let me know your feedback.
log.txt
.

@DominicKramer
Copy link
Contributor

I think the system test errors are independent of this PR. PR #212 fixes part of the system system tests. I am also working on another PR that fixes the installation tests. When those land, and you rebase, the system tests should pass on this PR.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@JustinBeckwith JustinBeckwith merged commit 6c6aa3a into googleapis:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants