Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: propagate spanIds #599

Merged
merged 22 commits into from
Jun 14, 2021
Merged

feat: propagate spanIds #599

merged 22 commits into from
Jun 14, 2021

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Jun 7, 2021 •
edited
Loading

Fixes #597 🦕

Blocked: Nodejs-logging release

Changes:

  • Users can now hardcode a spanId via LOGGING_SPAN_KEY when using Winston
  • Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs.
  • Fix e2e tests given originalUrl needs to be a real url
  • export function getCurrentTraceFromAgent

@0xSage 0xSage self-assigned this Jun 7, 2021
@0xSage 0xSage requested review from a team as code owners June 7, 2021 06:18
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-winston API. label Jun 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2021
@0xSage 0xSage changed the title feat: propagate use provided spanIds feat: propagate user provided spanIds Jun 7, 2021
@0xSage 0xSage marked this pull request as draft June 7, 2021 06:42
@0xSage 0xSage changed the title feat: propagate user provided spanIds feat: propagate spanIds Jun 7, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@0xSage 0xSage added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 7, 2021
@0xSage 0xSage marked this pull request as ready for review June 7, 2021 08:01
simonz130
simonz130 reviewed Jun 7, 2021
View reviewed changes
src/common.ts Show resolved Hide resolved
src/common.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@snippet-bot
Copy link

snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@0xSage 0xSage linked an issue Jun 11, 2021 that may be closed by this pull request
Extract spanId from metadata to populate LogEntry in the same way as trace #559
Closed
@0xSage 0xSage linked an issue Jun 11, 2021 that may be closed by this pull request
Export getCurrentTraceFromAgent for correlation with traces #459
Closed
@0xSage 0xSage added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2021
@0xSage 0xSage added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6a34151 into master Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the detectSpan branch June 14, 2021 09:34
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 14, 2021
@release-please
chore: release 4.1.0 (#608)
de372cc 
🤖 I have created a release \*beep\* \*boop\*
---
## [4.1.0](https://www.github.com/googleapis/nodejs-logging-winston/compare/v4.0.5...v4.1.0) (2021-06-14)


### Features

* propagate spanIds  ([#599](https://www.github.com/googleapis/nodejs-logging-winston/issues/599)) ([6a34151](https://www.github.com/googleapis/nodejs-logging-winston/commit/6a341511ec195282d14bb05ccae7752c91bdd36c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonz130 simonz130 simonz130 approved these changes

Assignees

@0xSage 0xSage

Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@0xSage @simonz130 @yoshi-kokoro