Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update dependency @google-cloud/logging from 9.0.0 to 9.6.9 #667

Merged
merged 9 commits into from
Feb 16, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Feb 15, 2022

This is a fix to expose a default callback from Options used by LoggingWinston so it would be propagated to Log constructor from @google-cloud/logging npm package. Also, update @google-cloud/logging dependency to 9.6.9.

Fixes #666 🦕

@losalex losalex requested review from a team as code owners February 15, 2022 23:01
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 15, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-winston API. label Feb 15, 2022
@arbrown arbrown linked an issue Feb 15, 2022 that may be closed by this pull request
test/common.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Feb 16, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

.readme-partials.yaml Outdated Show resolved Hide resolved
.readme-partials.yaml Outdated Show resolved Hide resolved
.readme-partials.yaml Show resolved Hide resolved
.readme-partials.yaml Outdated Show resolved Hide resolved
@losalex losalex merged commit 6fcda1e into main Feb 16, 2022
@losalex losalex deleted the losalex/fix-666 branch February 16, 2022 07:03
@losalex losalex assigned losalex and unassigned minherz Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency @google-cloud/logging from 9.0.0 to 9.6.9
4 participants