-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update dependency @google-cloud/logging from 9.0.0 to 9.6.9 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
Issues related to the googleapis/nodejs-logging-winston API.
label
Feb 15, 2022
arbrown
approved these changes
Feb 15, 2022
simonz130
approved these changes
Feb 15, 2022
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: xs
Pull request size is extra small.
labels
Feb 16, 2022
Warning: This pull request is touching the following templated files:
|
arbrown
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/nodejs-logging-winston API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to expose a default callback from
Options
used byLoggingWinston
so it would be propagated toLog
constructor from@google-cloud/logging
npm package. Also, update@google-cloud/logging
dependency to 9.6.9.Fixes #666 🦕