Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: patch Windows container, fixing Node 10 #468

Merged
merged 2 commits into from
May 7, 2019
Merged

build: patch Windows container, fixing Node 10 #468

merged 2 commits into from
May 7, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 6, 2019

temporary patch broken Windows container, such that tests can be run on Node 10

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2019
@callmehiphop callmehiphop added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2019
@codecov
Copy link

codecov bot commented May 7, 2019 •
edited

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          10       10           
  Lines         449      449           
  Branches       74       74           
=======================================
  Hits          421      421           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd4049...6393a69. Read the comment docs.

@bcoe bcoe merged commit 0d3921f into master May 7, 2019
@bcoe bcoe deleted the node-10-windows branch May 7, 2019 04:54
yoshi-automation added a commit that referenced this pull request Apr 7, 2020
@yoshi-automation
fix: apache license URL (#468)
544f831 
googleapis/synthtool@1df68ed
commit 1df68ed6735ddce6797d0f83641a731c3c3f75b4
Author: Alexander Fenster <fenster@google.com>
Date:   Mon Apr 6 16:17:34 2020 -0700

    fix: apache license URL (#468)
yoshi-automation added a commit that referenced this pull request Apr 8, 2020
@yoshi-automation
fix: apache license URL (#468)
51f76ed 
googleapis/synthtool@1df68ed
commit 1df68ed6735ddce6797d0f83641a731c3c3f75b4
Author: Alexander Fenster <fenster@google.com>
Date:   Mon Apr 6 16:17:34 2020 -0700

    fix: apache license URL (#468)
yoshi-automation added a commit that referenced this pull request Apr 9, 2020
@yoshi-automation
fix: apache license URL (#468)
9e3e914 
googleapis/synthtool@1df68ed
commit 1df68ed6735ddce6797d0f83641a731c3c3f75b4
Author: Alexander Fenster <fenster@google.com>
Date:   Mon Apr 6 16:17:34 2020 -0700

    fix: apache license URL (#468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callmehiphop callmehiphop callmehiphop approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoe @callmehiphop @googlebot @kokoro-team