Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tests): fix coveralls and enable build cop #175

Merged
merged 6 commits into from Mar 23, 2020
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 6, 2020

No description provided.

@bcoe bcoe requested a review from feywind March 6, 2020 22:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2020
@googleapis googleapis deleted a comment from gcf-merge-on-green bot Mar 9, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 9, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #175 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          220       220           
  Branches        32        36    +4     
=========================================
  Hits           220       220           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6d3c5...f3ac8b4. Read the comment docs.

@bcoe bcoe merged commit 7b703ce into master Mar 23, 2020
@bcoe bcoe deleted the modernize-tests branch March 23, 2020 17:55
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
7b703ce
commit 7b703ce
Author: Benjamin E. Coe <bencoe@google.com>
Date:   Mon Mar 23 10:55:24 2020 -0700

    build(tests): fix coveralls and enable build cop (#175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants