fix: allow excluding accessor methods #228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on googleapis/nodejs-bigtable#794, I noticed some accessor methods were being unexpectedly called by this module, even though they were excluded. Example:
This is because of the ordering which this module checks what methods from a prototype should be excluded:
In this case, step 1 was what caused the error:
The easiest way to solve this seemed to be to just bump step 3 up to step 1-- if the user wants it excluded, why do any other guessing?