fix(publisher): unbound max send message size (#454)

googleapis · Jan 29, 2019 · 773a05c · 773a05c
1 parent 462eecc
commit 773a05c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 22 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -272,6 +272,7 @@ export class PubSub {
     this.options = Object.assign(
         {
           'grpc.keepalive_time_ms': 300000,
+          'grpc.max_send_message_length': -1,
           'grpc.max_receive_message_length': 20000001,
           libName: 'gccl',
           libVersion: PKG.version,

diff --git a/test/index.ts b/test/index.ts
@@ -183,6 +183,15 @@ describe('PubSub', () => {
   });
 
   describe('instantiation', () => {
+    const DEFAULT_OPTIONS = {
+      'grpc.keepalive_time_ms': 300000,
+      'grpc.max_send_message_length': -1,
+      'grpc.max_receive_message_length': 20000001,
+      libName: 'gccl',
+      libVersion: PKG.version,
+      scopes: [],
+    };
+
     it('should extend the correct methods', () => {
       assert(extended);  // See `fakePaginator.extend`
     });
@@ -236,19 +245,10 @@ describe('PubSub', () => {
         a: 'b',
         c: 'd',
       };
+      const expectedOptions = Object.assign({}, DEFAULT_OPTIONS, options);
 
       googleAuthOverride = options_ => {
-        assert.deepStrictEqual(
-            options_,
-            Object.assign(
-                {
-                  'grpc.max_receive_message_length': 20000001,
-                  'grpc.keepalive_time_ms': 300000,
-                  libName: 'gccl',
-                  libVersion: PKG.version,
-                  scopes: [],
-                },
-                options));
+        assert.deepStrictEqual(options_, expectedOptions);
         return fakeGoogleAuthInstance;
       };
 
@@ -257,17 +257,9 @@ describe('PubSub', () => {
     });
 
     it('should localize the options provided', () => {
-      assert.deepStrictEqual(
-          pubsub.options,
-          Object.assign(
-              {
-                'grpc.max_receive_message_length': 20000001,
-                'grpc.keepalive_time_ms': 300000,
-                libName: 'gccl',
-                libVersion: PKG.version,
-                scopes: [],
-              },
-              OPTIONS));
+      const expectedOptions = Object.assign({}, DEFAULT_OPTIONS, OPTIONS);
+
+      assert.deepStrictEqual(pubsub.options, expectedOptions);
     });
 
     it('should set the projectId', () => {