build: update gapic-generator-typescript to v4.4.1 (#1883)

* build: update gapic-generator-typescript to v4.4.1 PiperOrigin-RevId: 604765466 Source-Link: googleapis/googleapis@40203ca Source-Link: googleapis/googleapis-gen@07b7f3d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDdiN2YzZGFkOGFhMTkxMmQ0YWNkY2ZkNjM2NWJiNDIzNmU0YjU0YiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Feb 8, 2024 · dbd1b2c · dbd1b2c
1 parent b1069e4
commit dbd1b2c
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 66 deletions.
diff --git a/src/v1/publisher_client.ts b/src/v1/publisher_client.ts
@@ -345,7 +345,7 @@ export class PublisherClient {
 
   /**
    * The DNS address for this API service.
-   * @deprecated
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get servicePath() {
@@ -362,9 +362,8 @@ export class PublisherClient {
   }
 
   /**
-   * The DNS address for this API service - same as servicePath,
-   * exists for compatibility reasons.
-   * @deprecated
+   * The DNS address for this API service - same as servicePath.
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get apiEndpoint() {
@@ -384,14 +383,6 @@ export class PublisherClient {
    * The DNS address for this API service.
    * @returns {string} The DNS address for this service.
    */
-  get servicePath() {
-    return this._servicePath;
-  }
-
-  /**
-   * The DNS address for this API service - same as servicePath().
-   * @returns {string} The DNS address for this service.
-   */
   get apiEndpoint() {
     return this._servicePath;
   }

diff --git a/src/v1/schema_service_client.ts b/src/v1/schema_service_client.ts
@@ -321,7 +321,7 @@ export class SchemaServiceClient {
 
   /**
    * The DNS address for this API service.
-   * @deprecated
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get servicePath() {
@@ -338,9 +338,8 @@ export class SchemaServiceClient {
   }
 
   /**
-   * The DNS address for this API service - same as servicePath,
-   * exists for compatibility reasons.
-   * @deprecated
+   * The DNS address for this API service - same as servicePath.
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get apiEndpoint() {
@@ -360,14 +359,6 @@ export class SchemaServiceClient {
    * The DNS address for this API service.
    * @returns {string} The DNS address for this service.
    */
-  get servicePath() {
-    return this._servicePath;
-  }
-
-  /**
-   * The DNS address for this API service - same as servicePath().
-   * @returns {string} The DNS address for this service.
-   */
   get apiEndpoint() {
     return this._servicePath;
   }

diff --git a/src/v1/subscriber_client.ts b/src/v1/subscriber_client.ts
@@ -354,7 +354,7 @@ export class SubscriberClient {
 
   /**
    * The DNS address for this API service.
-   * @deprecated
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get servicePath() {
@@ -371,9 +371,8 @@ export class SubscriberClient {
   }
 
   /**
-   * The DNS address for this API service - same as servicePath,
-   * exists for compatibility reasons.
-   * @deprecated
+   * The DNS address for this API service - same as servicePath.
+   * @deprecated Use the apiEndpoint method of the client instance.
    * @returns {string} The DNS address for this service.
    */
   static get apiEndpoint() {
@@ -393,14 +392,6 @@ export class SubscriberClient {
    * The DNS address for this API service.
    * @returns {string} The DNS address for this service.
    */
-  get servicePath() {
-    return this._servicePath;
-  }
-
-  /**
-   * The DNS address for this API service - same as servicePath().
-   * @returns {string} The DNS address for this service.
-   */
   get apiEndpoint() {
     return this._servicePath;
   }

diff --git a/test/gapic_publisher_v1.ts b/test/gapic_publisher_v1.ts
@@ -129,12 +129,6 @@ function stubAsyncIterationCall<ResponseType>(
 
 describe('v1.PublisherClient', () => {
   describe('Common methods', () => {
-    it('has servicePath', () => {
-      const client = new publisherModule.v1.PublisherClient();
-      const servicePath = client.servicePath;
-      assert.strictEqual(servicePath, 'pubsub.googleapis.com');
-    });
-
     it('has apiEndpoint', () => {
       const client = new publisherModule.v1.PublisherClient();
       const apiEndpoint = client.apiEndpoint;
@@ -167,19 +161,19 @@ describe('v1.PublisherClient', () => {
         stub.restore();
       });
     }
-    it('sets servicePath according to universe domain camelCase', () => {
+    it('sets apiEndpoint according to universe domain camelCase', () => {
       const client = new publisherModule.v1.PublisherClient({
         universeDomain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'pubsub.example.com');
     });
 
-    it('sets servicePath according to universe domain snakeCase', () => {
+    it('sets apiEndpoint according to universe domain snakeCase', () => {
       const client = new publisherModule.v1.PublisherClient({
         universe_domain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'pubsub.example.com');
     });
     it('does not allow setting both universeDomain and universe_domain', () => {

diff --git a/test/gapic_schema_service_v1.ts b/test/gapic_schema_service_v1.ts
@@ -129,12 +129,6 @@ function stubAsyncIterationCall<ResponseType>(
 
 describe('v1.SchemaServiceClient', () => {
   describe('Common methods', () => {
-    it('has servicePath', () => {
-      const client = new schemaserviceModule.v1.SchemaServiceClient();
-      const servicePath = client.servicePath;
-      assert.strictEqual(servicePath, 'pubsub.googleapis.com');
-    });
-
     it('has apiEndpoint', () => {
       const client = new schemaserviceModule.v1.SchemaServiceClient();
       const apiEndpoint = client.apiEndpoint;
@@ -169,19 +163,19 @@ describe('v1.SchemaServiceClient', () => {
         stub.restore();
       });
     }
-    it('sets servicePath according to universe domain camelCase', () => {
+    it('sets apiEndpoint according to universe domain camelCase', () => {
       const client = new schemaserviceModule.v1.SchemaServiceClient({
         universeDomain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'pubsub.example.com');
     });
 
-    it('sets servicePath according to universe domain snakeCase', () => {
+    it('sets apiEndpoint according to universe domain snakeCase', () => {
       const client = new schemaserviceModule.v1.SchemaServiceClient({
         universe_domain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'pubsub.example.com');
     });
     it('does not allow setting both universeDomain and universe_domain', () => {

diff --git a/test/gapic_subscriber_v1.ts b/test/gapic_subscriber_v1.ts
@@ -143,12 +143,6 @@ function stubAsyncIterationCall<ResponseType>(
 
 describe('v1.SubscriberClient', () => {
   describe('Common methods', () => {
-    it('has servicePath', () => {
-      const client = new subscriberModule.v1.SubscriberClient();
-      const servicePath = client.servicePath;
-      assert.strictEqual(servicePath, 'pubsub.googleapis.com');
-    });
-
     it('has apiEndpoint', () => {
       const client = new subscriberModule.v1.SubscriberClient();
       const apiEndpoint = client.apiEndpoint;
@@ -181,19 +175,19 @@ describe('v1.SubscriberClient', () => {
         stub.restore();
       });
     }
-    it('sets servicePath according to universe domain camelCase', () => {
+    it('sets apiEndpoint according to universe domain camelCase', () => {
       const client = new subscriberModule.v1.SubscriberClient({
         universeDomain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'pubsub.example.com');
     });
 
-    it('sets servicePath according to universe domain snakeCase', () => {
+    it('sets apiEndpoint according to universe domain snakeCase', () => {
       const client = new subscriberModule.v1.SubscriberClient({
         universe_domain: 'example.com',
       });
-      const servicePath = client.servicePath;
+      const servicePath = client.apiEndpoint;
       assert.strictEqual(servicePath, 'pubsub.example.com');
     });
     it('does not allow setting both universeDomain and universe_domain', () => {